marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

Component - Radios #173

Closed Toshibot closed 3 years ago

Toshibot commented 4 years ago

Radios

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

ti10le commented 3 years ago

With the last commmit to to PR #296 the radio button is nearly completed. Missing:

ti10le commented 3 years ago

@sebald @viktoria-schwarz How we should handle this two points?

sebald commented 3 years ago

1) That's a statement not a problem? :-D 2) So adjust the label? I am not sure what's better for a11y here. I guess also do a pointer over the label?

ti10le commented 3 years ago

@sebald

  1. Ok, maybe later if we need this.
  2. Yes we would have to change the label. I think basically it is better if the label is clickable.
sebald commented 3 years ago
  1. maybe it's because you have state inside the <Radio> as mentioned in a comment, this is not correct. Maybe lets talk about this on Monday? CC @viktoria-schwarz
sebald commented 3 years ago

BTW, the radio does not work for me (can select multiple in the demo) is this known?

ti10le commented 3 years ago

Oh yes, that changed. Worked at first. I'll fix it.