search

marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

chore: switch from yarn 3 to pnpm #1850

Closed sebald closed 2 years ago

sebald commented 2 years ago

note: pnpm does things a little bit different than other package manager when it comes to hoisting of packages. Basically, it is more strict, which is good. But since we want some types globally available we have to hoist some of the packages so that tooling (like VSCode) can pick it up correctly.

Also, it is still annoying af that storybook has an old version of emotion and interferes with our types...

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: 578726d7dab927748e3bb5e7480f638c4c4aeb13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sebald commented 2 years ago

@sarahgm @ti10le To test this PR you have to install pnpm. See https://pnpm.io/installation for instructions. I just did npm -g pnpm. Also, make sure to use node 16 🙂

sebald commented 2 years ago

~...will investigate why after the merge the tests fail, very weird >.<~

Fixed!

ti10le commented 2 years ago

needs a changeset @sebald?

sebald commented 2 years ago

needs a changeset @sebald?

@ti10le y? There is no public change

ti10le commented 2 years ago

@sebald I cant run gatsby develop from /docs folder. Can't resolve some packages in '/Users/timozehnle/Projects/rx/marigold/docs/.cache' I've deleted cache, node_modules, pnpm-lock.yaml, made pnpm clean and build but it has no effect.

sebald commented 2 years ago

Is this the error? Will look into it. Can you run it from root?

ti10le commented 2 years ago

nope.. same error.

sebald commented 2 years ago

@ti10le okay so ist doesn't open the GitHub Repo, like you mentioned in another comment? xD

ti10le commented 2 years ago

@ti10le okay so ist doesn't open the GitHub Repo, like you mentioned in another comment? xD

For me it opened the github repo when I did pnpm docs. I get the error I posted above when I do pnpm start from the docs directory to start docs.