marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

Introducing <DateField> Component #2953

Closed OsamaAbdellateef closed 1 year ago

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: af10b32900493c79431bd69e38cbd4b1bd42bc56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | -------------------------- | ----- | | @marigold/components | Major | | @marigold/theme-b2b | Major | | @marigold/storybook-config | Patch | | @marigold/docs | Major | | @marigold/theme-core | Major | | @marigold/theme-unicorn | Major | | @marigold/system | Major | | @marigold/icons | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 year ago

Codecov Report

Merging #2953 (e217bff) into main (c225edb) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head e217bff differs from pull request most recent head af10b32. Consider uploading reports for the commit af10b32 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #2953    +/-   ##
========================================
  Coverage   99.97%   99.97%            
========================================
  Files         112      114     +2     
  Lines        7209     7517   +308     
  Branches      338      358    +20     
========================================
+ Hits         7207     7515   +308     
  Misses          2        2            
Impacted Files Coverage Δ
packages/components/src/DateField/DateField.tsx 100.00% <100.00%> (ø)
packages/components/src/DateField/DateSegment.tsx 100.00% <100.00%> (ø)
packages/components/src/theme.ts 100.00% <100.00%> (ø)
sarahgm commented 1 year ago

Can you add border styles for the core theme and unicorn?

Bildschirm­foto 2023-04-25 um 15 30 48
sarahgm commented 1 year ago

One thing left: Can we have the action icon (the Calendar) always in Date Field ?

OsamaAbdellateef commented 1 year ago

Can you add border styles for the core theme and unicorn? Bildschirm­foto 2023-04-25 um 15 30 48

fixed

OsamaAbdellateef commented 1 year ago

One thing left: Can we have the action icon (the Calendar) always in Date Field ?

Added

sarahgm commented 1 year ago

documentation missing

sarahgm commented 1 year ago

Can you add border styles for the core theme and unicorn? Bildschirm­foto 2023-04-25 um 15 30 48

fixed

looks good but can you also add a background? it shouldn't have the same color as the background @OsamaAbdellateef