Closed sebald closed 11 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
marigold | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 7, 2023 0:06am |
@sebald typecheck and test :o
@sarahgm fixed :)
Merging #3020 (49cbe9d) into tailwind-variants (cb65c7e) will decrease coverage by
0.05%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## tailwind-variants #3020 +/- ##
=====================================================
- Coverage 86.56% 86.52% -0.05%
=====================================================
Files 156 156
Lines 8536 8510 -26
Branches 354 352 -2
=====================================================
- Hits 7389 7363 -26
Misses 1113 1113
Partials 34 34
Impacted Files | Coverage Δ | |
---|---|---|
packages/components/src/DateField/DateField.tsx | 100.00% <100.00%> (ø) |
|
packages/components/src/DateField/DateSegment.tsx | 100.00% <100.00%> (ø) |
|
packages/components/src/DatePicker/DatePicker.tsx | 100.00% <100.00%> (ø) |
@sebald what about these lint warnings? Should this be resolved?
@sebald what about these lint warnings? Should this be resolved?
Maybe we should change them to be an error?
@sebald yes do you know how? I can merge this than, right?
@sebald yes do you know how? I can merge this than, right?
Yes.
For the lint stuff: needs to be changed in our config
⚠️ No Changeset found
Latest commit: 49cbe9d8e1329d1c8259fdea01590136b62913d5
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
💥 An error occurred when fetching the changed packages and changesets in this PR
``` Some errors occurred when validating the changesets config: The package or glob expression "@marigold/docs" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch. ```