Closed OsamaAbdellateef closed 10 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
marigold | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 11, 2023 6:10am |
marigold-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 11, 2023 6:10am |
Merging #3086 (586d31f) into main (9fd24c9) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #3086 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 6808 6808
Branches 301 301
=========================================
Hits 6808 6808
@OsamaAbdellateef this looks great, do you want to merge this or work in this branch for a refunded version?
PS: we need to specify what the code demi should be able to do 😀
@OsamaAbdellateef this looks great, do you want to merge this or work in this branch for a refunded version?
PS: we need to specify what the code demi should be able to do 😀
@OsamaAbdellateef this looks great, do you want to merge this or work in this branch for a refunded version?
PS: we need to specify what the code demi should be able to do grinning
Yes i think we can merge and i guess demo will be used to change the logic , variants or size or even logic stuff
@OsamaAbdellateef this looks great, do you want to merge this or work in this branch for a refunded version? PS: we need to specify what the code demi should be able to do grinning
Yes i think we can merge and i guess demo will be used to change the logic , variants or size or even logic stuff
I'll resolve the conflicts first
@OsamaAbdellateef Have I forget something or why does is has no style on my screen? Counter has styles
also I get a warning in browser console: Warning: CodeEditor: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead
@OsamaAbdellateef I think we can close this?
@OsamaAbdellateef I think we can close this?
@sebald Yes Sure i will close it
⚠️ No Changeset found
Latest commit: d5020d4a5bf4db64199f19c4ce11adbe727d6554
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver typesClick here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR