marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

docs[DST-72] Adding live demo #3086

Closed OsamaAbdellateef closed 10 months ago

changeset-bot[bot] commented 10 months ago

⚠️ No Changeset found

Latest commit: d5020d4a5bf4db64199f19c4ce11adbe727d6554

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2023 6:10am
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2023 6:10am
codecov[bot] commented 10 months ago

Codecov Report

Merging #3086 (586d31f) into main (9fd24c9) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #3086   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines         6808      6808           
  Branches       301       301           
=========================================
  Hits          6808      6808           
sebald commented 10 months ago

@OsamaAbdellateef this looks great, do you want to merge this or work in this branch for a refunded version?

PS: we need to specify what the code demi should be able to do 😀

sebald commented 10 months ago

@OsamaAbdellateef this looks great, do you want to merge this or work in this branch for a refunded version?

PS: we need to specify what the code demi should be able to do 😀

OsamaAbdellateef commented 10 months ago

@OsamaAbdellateef this looks great, do you want to merge this or work in this branch for a refunded version?

PS: we need to specify what the code demi should be able to do grinning

Yes i think we can merge and i guess demo will be used to change the logic , variants or size or even logic stuff

OsamaAbdellateef commented 10 months ago

@OsamaAbdellateef this looks great, do you want to merge this or work in this branch for a refunded version? PS: we need to specify what the code demi should be able to do grinning

Yes i think we can merge and i guess demo will be used to change the logic , variants or size or even logic stuff

I'll resolve the conflicts first

sarahgm commented 10 months ago

@OsamaAbdellateef Have I forget something or why does is has no style on my screen? Counter has styles

Bildschirmfoto 2023-07-06 um 09 14 22
sarahgm commented 10 months ago

also I get a warning in browser console: Warning: CodeEditor: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead

sebald commented 10 months ago

@OsamaAbdellateef I think we can close this?

OsamaAbdellateef commented 10 months ago

@OsamaAbdellateef I think we can close this?

@sebald Yes Sure i will close it