marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

[DST-63]: Adding`useSmallScreen` hook #3087

Closed OsamaAbdellateef closed 10 months ago

changeset-bot[bot] commented 10 months ago

⚠️ No Changeset found

Latest commit: 93c29d386efcd4cb86a4f08ec161e50822ca21ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 10:25am
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 10:25am
codecov[bot] commented 10 months ago

Codecov Report

Merging #3087 (ee99f83) into main (9fbf356) will decrease coverage by 0.03%. The diff coverage is 93.33%.

:exclamation: Current head ee99f83 differs from pull request most recent head 93c29d3. Consider uploading reports for the commit 93c29d3 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##              main    #3087      +/-   ##
===========================================
- Coverage   100.00%   99.97%   -0.03%     
===========================================
  Files          110      111       +1     
  Lines         6846     6871      +25     
  Branches       305      311       +6     
===========================================
+ Hits          6846     6869      +23     
- Misses           0        2       +2     
Impacted Files Coverage Δ
packages/system/src/hooks/useSmallScreen.ts 92.30% <92.30%> (ø)
packages/components/src/Menu/MenuTrigger.tsx 100.00% <100.00%> (ø)
packages/components/src/Select/Select.tsx 100.00% <100.00%> (ø)
sebald commented 10 months ago

@OsamaAbdellateef can you also use it in components previously used useResponsive hook? :)

OsamaAbdellateef commented 10 months ago

@OsamaAbdellateef can you also use it in components previously used useResponsive hook? :)

Done :100:

OsamaAbdellateef commented 10 months ago

@OsamaAbdellateef can you also use it in components previously used useResponsive hook? :)

@sebald Done 100

sebald commented 10 months ago

There is an issue with the docs build, guess we have to check if window exists 🙈

OsamaAbdellateef commented 10 months ago

There is an issue with the docs build, guess we have to check if window exists see_no_evil

@sebald Done :ballot_box_with_check: handled window issue and added test for it