search

marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

[DST-110]: Share `Field` Styles across multiple Components #3248

Closed OsamaAbdellateef closed 9 months ago

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 7:09am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 7:09am
codecov[bot] commented 9 months ago

Codecov Report

Merging #3248 (45287ae) into main (9861b88) will not change coverage. Report is 7 commits behind head on main. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #3248   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          112       112           
  Lines         7088      7088           
  Branches       319       319           
=========================================
  Hits          7088      7088
sarahgm commented 9 months ago

what is with the other form components? Isn't it also possible? @OsamaAbdellateef

OsamaAbdellateef commented 9 months ago

what is with the other form components? Isn't it also possible? @OsamaAbdellateef

what is with the other form components? Isn't it also possible? @OsamaAbdellateef @sarahgm like what ?

sarahgm commented 9 months ago

what is with the other form components? Isn't it also possible? @OsamaAbdellateef

what is with the other form components? Isn't it also possible? @OsamaAbdellateef @sarahgm like what ?

to use the styles? DateField, TextField and so on :D I was just wondering @OsamaAbdellateef

changeset-bot[bot] commented 9 months ago

⚠️ No Changeset found

Latest commit: 45287aea999959e6459676f3811b30067f158bcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

OsamaAbdellateef commented 9 months ago

what is with the other form components? Isn't it also possible? @OsamaAbdellateef

what is with the other form components? Isn't it also possible? @OsamaAbdellateef @sarahgm like what ?

to use the styles? DateField, TextField and so on :D I was just wondering @OsamaAbdellateef

@sarahgm Yeah most of them are unified because they use the same Input component but not all of them, and i added styles for components that aren't using Input