Closed OsamaAbdellateef closed 8 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
marigold-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 31, 2023 9:48am |
marigold-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 31, 2023 9:48am |
Hey @OsamaAbdellateef are you still on this or is it ready for rewiew?
@sarahgm Still got an issue and can't find a solution for it , it is only one test :"( I am trying to test if there's no window , so i mock that there's no window and then i try to use renderHook but can't be used wihtout a window :)
In ThemeSwitch.test.tsx
still '@testing-library/react-hooks';
is used
@OsamaAbdellateef hm... what have you tired out?
@OsamaAbdellateef hm... what have you tired out?
I will let you know in details in meeting @sarahgm
Merging #3310 (d50f348) into main (a5515f3) will decrease coverage by
0.03%
. Report is 3 commits behind head on main. The diff coverage is100.00%
.
⚠️ No Changeset found
Latest commit: d50f3487c993508a3fe812d2a059f2f4ae1bb63b
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver typesClick here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR