marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

[DST-159]: Remove "@testing-library/react-hooks" #3310

Closed OsamaAbdellateef closed 8 months ago

changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: d50f3487c993508a3fe812d2a059f2f4ae1bb63b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 9:48am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 9:48am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **marigold-production** | ⬜️ Ignored ([Inspect](https://vercel.com/marigold/marigold-production/HnHvm67Vx4pmSAVkw4BSCUAvTs4w)) | [Visit Preview](https://marigold-production-git-update-testing-library-marigold.vercel.app) | | Aug 31, 2023 9:48am |
sarahgm commented 8 months ago

Hey @OsamaAbdellateef are you still on this or is it ready for rewiew?

OsamaAbdellateef commented 8 months ago

@sarahgm Still got an issue and can't find a solution for it , it is only one test :"( I am trying to test if there's no window , so i mock that there's no window and then i try to use renderHook but can't be used wihtout a window :)

sarahgm commented 8 months ago

In ThemeSwitch.test.tsx still '@testing-library/react-hooks'; is used

sarahgm commented 8 months ago

@OsamaAbdellateef hm... what have you tired out?

OsamaAbdellateef commented 8 months ago

@OsamaAbdellateef hm... what have you tired out?

I will let you know in details in meeting @sarahgm

codecov[bot] commented 8 months ago

Codecov Report

Merging #3310 (d50f348) into main (a5515f3) will decrease coverage by 0.03%. Report is 3 commits behind head on main. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/marigold-ui/marigold/pull/3310/graphs/tree.svg?width=650&height=150&src=pr&token=YIIcKX7TZu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)](https://app.codecov.io/gh/marigold-ui/marigold/pull/3310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) ```diff @@ Coverage Diff @@ ## main #3310 +/- ## =========================================== - Coverage 100.00% 99.97% -0.03% =========================================== Files 117 117 Lines 7548 7549 +1 Branches 324 325 +1 =========================================== - Hits 7548 7547 -1 - Misses 0 2 +2 ``` | [Files Changed](https://app.codecov.io/gh/marigold-ui/marigold/pull/3310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) | Coverage Δ | | |---|---|---| | [packages/system/src/hooks/useResponsiveValue.ts](https://app.codecov.io/gh/marigold-ui/marigold/pull/3310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui#diff-cGFja2FnZXMvc3lzdGVtL3NyYy9ob29rcy91c2VSZXNwb25zaXZlVmFsdWUudHM=) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/marigold-ui/marigold/pull/3310/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)