marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

Creating MultiSelect component #3338

Closed OsamaAbdellateef closed 6 months ago

changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: 8e04101939d10d0adf6a9cd0b7742a31b52feae0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 1:45pm
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 1:45pm
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **marigold-production** | ⬜️ Ignored ([Inspect](https://vercel.com/marigold/marigold-production/62iq67fwvRwkaUy8YE3RL9z3Bbdm)) | [Visit Preview](https://marigold-production-git-multiselect-marigold.vercel.app) | | Sep 19, 2023 1:45pm |
codecov[bot] commented 8 months ago

Codecov Report

Merging #3338 (8e04101) into main (bf52779) will decrease coverage by 0.67%. Report is 45 commits behind head on main. The diff coverage is 26.08%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/marigold-ui/marigold/pull/3338/graphs/tree.svg?width=650&height=150&src=pr&token=YIIcKX7TZu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)](https://app.codecov.io/gh/marigold-ui/marigold/pull/3338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) ```diff @@ Coverage Diff @@ ## main #3338 +/- ## ========================================== - Coverage 99.97% 99.30% -0.67% ========================================== Files 117 117 Lines 7549 7617 +68 Branches 325 325 ========================================== + Hits 7547 7564 +17 - Misses 2 53 +51 ``` | [Files Changed](https://app.codecov.io/gh/marigold-ui/marigold/pull/3338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) | Coverage Δ | | |---|---|---| | [packages/components/src/ComboBox/ComboBox.tsx](https://app.codecov.io/gh/marigold-ui/marigold/pull/3338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui#diff-cGFja2FnZXMvY29tcG9uZW50cy9zcmMvQ29tYm9Cb3gvQ29tYm9Cb3gudHN4) | `73.71% <26.08%> (-26.29%)` | :arrow_down: |
OsamaAbdellateef commented 8 months ago

:label: in progress

sarahgm commented 6 months ago

should we close this since we are anyway refactoring with RAC?

sarahgm commented 6 months ago

should we close this since we are anyway refactoring with RAC?

@OsamaAbdellateef ?

OsamaAbdellateef commented 6 months ago

should we close this since we are anyway refactoring with RAC?

@OsamaAbdellateef ? yes i think so @sarahgm