marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

RAC: `Slider` Component #3400

Closed OsamaAbdellateef closed 6 months ago

changeset-bot[bot] commented 7 months ago

πŸ¦‹ Changeset detected

Latest commit: 2b6c196be48f3c19e47171ab7ee04d3023b93e9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | -------------------------- | ----- | | @marigold/components | Minor | | @marigold/storybook-config | Patch | | @marigold/docs | Minor | | @marigold/theme-b2b | Patch | | @marigold/theme-core | Patch | | @marigold/system | Minor | | @marigold/icons | Patch | | @marigold/theme-preset | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
marigold-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 23, 2023 0:23am
marigold-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 23, 2023 0:23am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **marigold-production** | ⬜️ Ignored ([Inspect](https://vercel.com/marigold/marigold-production/JHuBtamUSrJELtbJiUDir1EY1Tmc)) | [Visit Preview](https://marigold-production-git-rac-slider-marigold.vercel.app) | | Oct 23, 2023 0:23am |
codecov[bot] commented 7 months ago

Codecov Report

Merging #3400 (2b6c196) into main (470d00c) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/marigold-ui/marigold/pull/3400/graphs/tree.svg?width=650&height=150&src=pr&token=YIIcKX7TZu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)](https://app.codecov.io/gh/marigold-ui/marigold/pull/3400?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) ```diff @@ Coverage Diff @@ ## main #3400 +/- ## ========================================== - Coverage 99.97% 99.97% -0.01% ========================================== Files 119 118 -1 Lines 7616 7520 -96 Branches 338 339 +1 ========================================== - Hits 7614 7518 -96 Misses 2 2 ``` | [Files](https://app.codecov.io/gh/marigold-ui/marigold/pull/3400?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) | Coverage Ξ” | | |---|---|---| | [packages/components/src/Slider/Slider.tsx](https://app.codecov.io/gh/marigold-ui/marigold/pull/3400?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui#diff-cGFja2FnZXMvY29tcG9uZW50cy9zcmMvU2xpZGVyL1NsaWRlci50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
sebald commented 7 months ago

@OsamaAbdellateef font needs to be smaller in core :)

image

OsamaAbdellateef commented 7 months ago

@OsamaAbdellateef font needs to be smaller in core :)

image

Now i am using our label :100: :heavy_check_mark:

sebald commented 7 months ago

@OsamaAbdellateef for whatever reasons a test from the accordion is no longer working :D (I guess it is because of the fireEvent instead of useEvent)

OsamaAbdellateef commented 6 months ago

@OsamaAbdellateef for whatever reasons a test from the accordion is no longer working :D (I guess it is because of the fireEvent instead of useEvent) I changed this from fireEvent to userEvent but it seems that the warning is because of using onClick instead of onPress @sebald

sebald commented 6 months ago

@OsamaAbdellateef for whatever reasons a test from the accordion is no longer working :D (I guess it is because of the fireEvent instead of useEvent) I changed this from fireEvent to userEvent but it seems that the warning is because of using onClick instead of onPress @sebald

Warning is fine. As long as the test succeeds πŸ˜„