marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

refa: use non-rac checkbox in table #3450

Closed sebald closed 6 months ago

changeset-bot[bot] commented 6 months ago

πŸ¦‹ Changeset detected

Latest commit: cd88d2359c398e968b95f8694fdc6945163d9335

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | -------------------------- | ----- | | @marigold/components | Patch | | @marigold/storybook-config | Patch | | @marigold/docs | Patch | | @marigold/theme-b2b | Patch | | @marigold/theme-core | Patch | | @marigold/system | Patch | | @marigold/icons | Patch | | @marigold/theme-preset | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
marigold-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 25, 2023 2:18pm
marigold-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ 1 unresolved Oct 25, 2023 2:18pm
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **marigold-production** | ⬜️ Ignored ([Inspect](https://vercel.com/marigold/marigold-production/BxQXtDcNwaB1XBbbqAWwns2m1tYc)) | [Visit Preview](https://vercel.live/open-feedback/marigold-production-git-table-use-old-checkbox-marigold.vercel.app?via=pr-comment-visit-preview-link&passThrough=1) | πŸ’¬ [**Add feedback**](https://vercel.live/open-feedback/marigold-production-git-table-use-old-checkbox-marigold.vercel.app?via=pr-comment-feedback-link) | Oct 25, 2023 2:18pm |
sebald commented 6 months ago

@OsamaAbdellateef @sarahgm this makes it work again (AFAIK) but the checkboxes in the row are not styled anymore. why? :-O

codecov[bot] commented 6 months ago

Codecov Report

Merging #3450 (cd88d23) into main (547fca4) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/marigold-ui/marigold/pull/3450/graphs/tree.svg?width=650&height=150&src=pr&token=YIIcKX7TZu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)](https://app.codecov.io/gh/marigold-ui/marigold/pull/3450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) ```diff @@ Coverage Diff @@ ## main #3450 +/- ## ======================================= Coverage 99.97% 99.97% ======================================= Files 119 119 Lines 7542 7542 Branches 341 341 ======================================= Hits 7540 7540 Misses 2 2 ``` | [Files](https://app.codecov.io/gh/marigold-ui/marigold/pull/3450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) | Coverage Ξ” | | |---|---|---| | [...ackages/components/src/Table/TableCheckboxCell.tsx](https://app.codecov.io/gh/marigold-ui/marigold/pull/3450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui#diff-cGFja2FnZXMvY29tcG9uZW50cy9zcmMvVGFibGUvVGFibGVDaGVja2JveENlbGwudHN4) | `100.00% <100.00%> (ΓΈ)` | | | [...ckages/components/src/Table/TableSelectAllCell.tsx](https://app.codecov.io/gh/marigold-ui/marigold/pull/3450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui#diff-cGFja2FnZXMvY29tcG9uZW50cy9zcmMvVGFibGUvVGFibGVTZWxlY3RBbGxDZWxsLnRzeA==) | `100.00% <100.00%> (ΓΈ)` | |
sarahgm commented 6 months ago

@OsamaAbdellateef @sarahgm this makes it work again (AFAIK) but the checkboxes in the row are not styled anymore. why? :-O

maybe because the classnames slipped to another element?

sebald commented 6 months ago

@OsamaAbdellateef @sarahgm this makes it work again (AFAIK) but the checkboxes in the row are not styled anymore. why? :-O

maybe because the classnames slipped to another element?

But there is no className involved πŸ€” or is there?

sarahgm commented 6 months ago

@OsamaAbdellateef @sarahgm this makes it work again (AFAIK) but the checkboxes in the row are not styled anymore. why? :-O

maybe because the classnames slipped to another element?

But there is no className involved πŸ€” or is there?

I think about className.checkbox :)

sebald commented 6 months ago

superseeded by #3451