marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

RAC: add "Tray" behavior inside Popover #3536

Closed sarahgm closed 5 months ago

changeset-bot[bot] commented 5 months ago

πŸ¦‹ Changeset detected

Latest commit: 654884172a1d3725bff886bc84f3b110628170e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | -------------------------- | ----- | | @marigold/components | Patch | | @marigold/storybook-config | Patch | | @marigold/docs | Patch | | @marigold/theme-b2b | Patch | | @marigold/theme-core | Patch | | @marigold/system | Patch | | @marigold/icons | Patch | | @marigold/theme-preset | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
marigold-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 4, 2023 3:16pm
marigold-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 4, 2023 3:16pm
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **marigold-production** | ⬜️ Ignored ([Inspect](https://vercel.com/marigold/marigold-production/Fg5xixLj4ZYZvPdiLx1gYtuq3gVd)) | [Visit Preview](https://marigold-production-git-tray-react-aria-components-marigold.vercel.app) | | Dec 4, 2023 3:16pm |
codecov[bot] commented 5 months ago

Codecov Report

Merging #3536 (6548841) into main (0fab3af) will increase coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/marigold-ui/marigold/pull/3536/graphs/tree.svg?width=650&height=150&src=pr&token=YIIcKX7TZu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)](https://app.codecov.io/gh/marigold-ui/marigold/pull/3536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) ```diff @@ Coverage Diff @@ ## main #3536 +/- ## ======================================= Coverage 98.74% 98.74% ======================================= Files 124 124 Lines 7303 7322 +19 Branches 348 349 +1 ======================================= + Hits 7211 7230 +19 Misses 89 89 Partials 3 3 ``` | [Files](https://app.codecov.io/gh/marigold-ui/marigold/pull/3536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) | Coverage Ξ” | | |---|---|---| | [packages/components/src/Overlay/Popover.tsx](https://app.codecov.io/gh/marigold-ui/marigold/pull/3536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui#diff-cGFja2FnZXMvY29tcG9uZW50cy9zcmMvT3ZlcmxheS9Qb3BvdmVyLnRzeA==) | `100.00% <100.00%> (ΓΈ)` | |
sebald commented 5 months ago

@sarahgm merged, but I am not sure if the tray semantically should be a modal instead πŸ€”

sarahgm commented 5 months ago

@sarahgm merged, but I am not sure if the tray semantically should be a modal instead πŸ€”

but the Model is not used in Menu? Or how do you think? @sebald

sebald commented 5 months ago

No, I mean the tray is not a popover but a dialog since it blocks interaction with the rest of the page and is not placed relative to an element :)

sarahgm commented 5 months ago

I'm confused again. The popover is the only overlay element I thought inside the menu? @sebald

sebald commented 5 months ago

I'm confused again. The popover is the only overlay element I thought inside the menu? @sebald

if you are displaying the overpay next to the button yes