Closed sarahgm closed 5 months ago
The latest updates on your projects. Learn more about Vercel for Git βοΈ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
marigold-docs | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Dec 4, 2023 3:16pm |
marigold-storybook | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Dec 4, 2023 3:16pm |
Merging #3536 (6548841) into main (0fab3af) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@sarahgm merged, but I am not sure if the tray semantically should be a modal instead π€
@sarahgm merged, but I am not sure if the tray semantically should be a modal instead π€
but the Model is not used in Menu? Or how do you think? @sebald
No, I mean the tray is not a popover but a dialog since it blocks interaction with the rest of the page and is not placed relative to an element :)
I'm confused again. The popover is the only overlay element I thought inside the menu? @sebald
I'm confused again. The popover is the only overlay element I thought inside the menu? @sebald
if you are displaying the overpay next to the button yes
π¦ Changeset detected
Latest commit: 654884172a1d3725bff886bc84f3b110628170e3
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
| Name | Type | | -------------------------- | ----- | | @marigold/components | Patch | | @marigold/storybook-config | Patch | | @marigold/docs | Patch | | @marigold/theme-b2b | Patch | | @marigold/theme-core | Patch | | @marigold/system | Patch | | @marigold/icons | Patch | | @marigold/theme-preset | Patch |Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR