marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

[DST-134]:feat: Sticky Header #3593

Closed OsamaAbdellateef closed 4 months ago

changeset-bot[bot] commented 4 months ago

πŸ¦‹ Changeset detected

Latest commit: cce67428ad41996eb2247aa3db47cd5f5a4a9bf3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | -------------------------- | ----- | | @marigold/components | Minor | | @marigold/theme-b2b | Minor | | @marigold/docs | Minor | | @marigold/storybook-config | Patch | | @marigold/theme-core | Patch | | @marigold/system | Minor | | @marigold/icons | Patch | | @marigold/theme-preset | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
marigold-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ 1 unresolved
βœ… 1 resolved
Jan 17, 2024 9:40am
marigold-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 17, 2024 9:40am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **marigold-production** | ⬜️ Ignored ([Inspect](https://vercel.com/marigold/marigold-production/EuddXZj62mCstd8Sivy7iZWtXRBv)) | [Visit Preview](https://vercel.live/open-feedback/marigold-production-git-sticky-header-marigold.vercel.app?via=pr-comment-visit-preview-link&passThrough=1) | πŸ’¬ [**Add feedback**](https://vercel.live/open-feedback/marigold-production-git-sticky-header-marigold.vercel.app?via=pr-comment-feedback-link) | Jan 17, 2024 9:40am |
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (add4d9e) 99.83% compared to head (cce6742) 99.83%. Report is 28 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/marigold-ui/marigold/pull/3593/graphs/tree.svg?width=650&height=150&src=pr&token=YIIcKX7TZu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)](https://app.codecov.io/gh/marigold-ui/marigold/pull/3593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) ```diff @@ Coverage Diff @@ ## main #3593 +/- ## ======================================= Coverage 99.83% 99.83% ======================================= Files 116 116 Lines 6203 6213 +10 Branches 287 288 +1 ======================================= + Hits 6193 6203 +10 Misses 9 9 Partials 1 1 ``` | [Files](https://app.codecov.io/gh/marigold-ui/marigold/pull/3593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) | Coverage Ξ” | | |---|---|---| | [packages/components/src/Table/Table.tsx](https://app.codecov.io/gh/marigold-ui/marigold/pull/3593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui#diff-cGFja2FnZXMvY29tcG9uZW50cy9zcmMvVGFibGUvVGFibGUudHN4) | `100.00% <100.00%> (ΓΈ)` | | | [packages/components/src/Table/TableHeader.tsx](https://app.codecov.io/gh/marigold-ui/marigold/pull/3593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui#diff-cGFja2FnZXMvY29tcG9uZW50cy9zcmMvVGFibGUvVGFibGVIZWFkZXIudHN4) | `100.00% <100.00%> (ΓΈ)` | |
sarahgm commented 4 months ago

is this ready for review? :)

OsamaAbdellateef commented 4 months ago

is this ready for review? :) yes :+1: @sarahgm

sarahgm commented 4 months ago

@OsamaAbdellateef one small thing, can you add the prop in the props table in the mdx file? :)

OsamaAbdellateef commented 4 months ago

@OsamaAbdellateef one small thing, can you add the prop in the props table in the mdx file? :)

done :heavy_check_mark: @sarahgm