marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

[DST-358]: Exposing Listbox component #3707

Closed aromko closed 2 months ago

aromko commented 3 months ago
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: c16bc67819ccd88ad2ce8057d5a690eb768facc1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | -------------------------- | ----- | | @marigold/components | Minor | | @marigold/docs | Minor | | @marigold/storybook-config | Patch | | @marigold/theme-b2b | Patch | | @marigold/theme-core | Patch | | @marigold/system | Minor | | @marigold/icons | Patch | | @marigold/theme-preset | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 9:23am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 9:23am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **marigold-production** | ⬜️ Ignored ([Inspect](https://vercel.com/marigold/marigold-production/E5i47M8nmXvJcCLoqEX3oBBeWtjS)) | [Visit Preview](https://marigold-production-git-standalone-listbox-marigold.vercel.app) | | Feb 19, 2024 9:23am |
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (36c953c) 99.82% compared to head (7281bd3) 99.82%. Report is 38 commits behind head on main.

:exclamation: Current head 7281bd3 differs from pull request most recent head c16bc67. Consider uploading reports for the commit c16bc67 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/marigold-ui/marigold/pull/3707/graphs/tree.svg?width=650&height=150&src=pr&token=YIIcKX7TZu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)](https://app.codecov.io/gh/marigold-ui/marigold/pull/3707?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) ```diff @@ Coverage Diff @@ ## main #3707 +/- ## ======================================= Coverage 99.82% 99.82% ======================================= Files 119 119 Lines 6341 6342 +1 Branches 307 307 ======================================= + Hits 6330 6331 +1 Misses 10 10 Partials 1 1 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/marigold-ui/marigold/pull/3707/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)
sebald commented 3 months ago

@aromko @OsamaAbdellateef Deselecting an item seems not to work.

Kapture 2024-02-13 at 14.06.42.webm

OsamaAbdellateef commented 3 months ago

@aromko @OsamaAbdellateef Deselecting an item seems not to work.

Kapture.2024-02-13.at.14.04.28.webm the conflict comes from the styling, focus and selected have the same effect in core theme if you tried this with b2b theme you will notice that it works because focus and selected have the same effect @sebald

sebald commented 3 months ago

@OsamaAbdellateef ah I see, so I guess we need to adjust the stlyes 👀 Otherwise this is super weird

sarahgm commented 3 months ago

@OsamaAbdellateef @sebald @aromko is this caused by this you mean? https://reservix.atlassian.net/jira/software/projects/DST/boards/134?selectedIssue=DST-280

OsamaAbdellateef commented 3 months ago

@OsamaAbdellateef @sebald @aromko is this caused by this you mean? https://reservix.atlassian.net/jira/software/projects/DST/boards/134?selectedIssue=DST-280

Yes it is :100: @sarahgm