Closed aromko closed 2 months ago
Latest commit: c16bc67819ccd88ad2ce8057d5a690eb768facc1
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
marigold-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 19, 2024 9:23am |
marigold-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 19, 2024 9:23am |
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
36c953c
) 99.82% compared to head (7281bd3
) 99.82%. Report is 38 commits behind head on main.:exclamation: Current head 7281bd3 differs from pull request most recent head c16bc67. Consider uploading reports for the commit c16bc67 to get more accurate results
@aromko @OsamaAbdellateef Deselecting an item seems not to work.
@aromko @OsamaAbdellateef Deselecting an item seems not to work.
Kapture.2024-02-13.at.14.04.28.webm the conflict comes from the styling, focus and selected have the same effect in core theme if you tried this with b2b theme you will notice that it works because focus and selected have the same effect @sebald
@OsamaAbdellateef ah I see, so I guess we need to adjust the stlyes 👀 Otherwise this is super weird
@OsamaAbdellateef @sebald @aromko is this caused by this you mean? https://reservix.atlassian.net/jira/software/projects/DST/boards/134?selectedIssue=DST-280
@OsamaAbdellateef @sebald @aromko is this caused by this you mean? https://reservix.atlassian.net/jira/software/projects/DST/boards/134?selectedIssue=DST-280
Yes it is :100: @sarahgm