marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

[DST-367]: rac `SelectList` component #3708

Closed aromko closed 1 month ago

aromko commented 3 months ago

In order to solve the multiselect issue from TCO it could be a possible solution to use the gridlist from react-aria. It's similiar to a listbox but offers some other stuf, like action button which is maybe useful in future.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: bf7b88ac2c00c5b144c4273e297b157fbe4dba6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages | Name | Type | | -------------------------- | ----- | | @marigold/components | Minor | | @marigold/docs | Minor | | @marigold/storybook-config | Patch | | @marigold/theme-b2b | Patch | | @marigold/theme-core | Patch | | @marigold/system | Minor | | @marigold/icons | Patch | | @marigold/theme-preset | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 1 resolved Apr 8, 2024 1:44pm
marigold-storybook ✅ Ready (Inspect) Visit Preview 3 resolved Apr 8, 2024 1:44pm
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **marigold-production** | ⬜️ Ignored ([Inspect](https://vercel.com/marigold/marigold-production/2Y5d7X9J1eSzdKSWD3t3ZcpXx3YR)) | [Visit Preview](https://marigold-production-git-rac-gridlist-marigold.vercel.app) | | Apr 8, 2024 1:44pm |
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.59%. Comparing base (c25da22) to head (d28a9ab). Report is 1 commits behind head on main.

:exclamation: Current head d28a9ab differs from pull request most recent head bf7b88a. Consider uploading reports for the commit bf7b88a to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/marigold-ui/marigold/pull/3708/graphs/tree.svg?width=650&height=150&src=pr&token=YIIcKX7TZu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)](https://app.codecov.io/gh/marigold-ui/marigold/pull/3708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) ```diff @@ Coverage Diff @@ ## main #3708 +/- ## ========================================== - Coverage 99.63% 99.59% -0.04% ========================================== Files 122 125 +3 Lines 6557 6670 +113 Branches 322 323 +1 ========================================== + Hits 6533 6643 +110 - Misses 23 26 +3 Partials 1 1 ``` | [Files](https://app.codecov.io/gh/marigold-ui/marigold/pull/3708?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) | Coverage Δ | | |---|---|---| | [packages/components/src/SelectList/Context.ts](https://app.codecov.io/gh/marigold-ui/marigold/pull/3708?src=pr&el=tree&filepath=packages%2Fcomponents%2Fsrc%2FSelectList%2FContext.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui#diff-cGFja2FnZXMvY29tcG9uZW50cy9zcmMvU2VsZWN0TGlzdC9Db250ZXh0LnRz) | `100.00% <100.00%> (ø)` | | | [packages/components/src/SelectList/SelectList.tsx](https://app.codecov.io/gh/marigold-ui/marigold/pull/3708?src=pr&el=tree&filepath=packages%2Fcomponents%2Fsrc%2FSelectList%2FSelectList.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui#diff-cGFja2FnZXMvY29tcG9uZW50cy9zcmMvU2VsZWN0TGlzdC9TZWxlY3RMaXN0LnRzeA==) | `100.00% <100.00%> (ø)` | | | [...kages/components/src/SelectList/SelectListItem.tsx](https://app.codecov.io/gh/marigold-ui/marigold/pull/3708?src=pr&el=tree&filepath=packages%2Fcomponents%2Fsrc%2FSelectList%2FSelectListItem.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui#diff-cGFja2FnZXMvY29tcG9uZW50cy9zcmMvU2VsZWN0TGlzdC9TZWxlY3RMaXN0SXRlbS50c3g=) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/marigold-ui/marigold/pull/3708/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)
sarahgm commented 2 months ago

@aromko is this still a draft?

aromko commented 2 months ago

@aromko is this still a draft?

@sarahgm Yes. It's just the first try from our mob. We can decide in our next cycle when we continue with that or feel free to go on 😄

aromko commented 1 month ago

@OsamaAbdellateef Can't approve because I'm the creator of the PR. But it's fine for me now.

OsamaAbdellateef commented 1 month ago

@OsamaAbdellateef Can't approve because I'm the creator of the PR. But it's fine for me now. Then @sebald or @sarahgm can merge :smile: