search

marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

chore(deps): update babel monorepo #3855

Closed renovate[bot] closed 1 month ago

renovate[bot] commented 1 month ago

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@babel/core (source) 7.23.9 -> 7.24.3 age adoption passing confidence
@babel/plugin-syntax-flow (source) 7.23.3 -> 7.24.1 age adoption passing confidence

Release Notes

babel/babel (@​babel/core) ### [`v7.24.3`](https://togithub.com/babel/babel/blob/HEAD/CHANGELOG.md#v7243-2024-03-20) [Compare Source](https://togithub.com/babel/babel/compare/v7.24.1...v7.24.3) ##### :bug: Bug Fix - `babel-helper-module-imports` - [#​16370](https://togithub.com/babel/babel/pull/16370) fix: do not inject the same imported identifier multiple times ([@​ota-meshi](https://togithub.com/ota-meshi)) ### [`v7.24.1`](https://togithub.com/babel/babel/blob/HEAD/CHANGELOG.md#v7241-2024-03-19) [Compare Source](https://togithub.com/babel/babel/compare/v7.24.0...v7.24.1) ##### :bug: Bug Fix - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators` - [#​16350](https://togithub.com/babel/babel/pull/16350) Fix decorated class computed keys ordering ([@​JLHwung](https://togithub.com/JLHwung)) - [#​16344](https://togithub.com/babel/babel/pull/16344) Fix decorated class static field private access ([@​JLHwung](https://togithub.com/JLHwung)) - `babel-plugin-proposal-decorators`, `babel-plugin-proposal-json-modules`, `babel-plugin-transform-async-generator-functions`, `babel-plugin-transform-regenerator`, `babel-plugin-transform-runtime`, `babel-preset-env` - [#​16329](https://togithub.com/babel/babel/pull/16329) Respect `moduleName` for `@babel/runtime/regenerator` imports ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-pipeline-operator`, `babel-plugin-transform-class-properties` - [#​16331](https://togithub.com/babel/babel/pull/16331) Fix decorator memoiser binding kind ([@​JLHwung](https://togithub.com/JLHwung)) - `babel-helper-create-class-features-plugin`, `babel-helper-replace-supers`, `babel-plugin-proposal-decorators`, `babel-plugin-transform-class-properties` - [#​16325](https://togithub.com/babel/babel/pull/16325) Fix decorator evaluation private environment ([@​JLHwung](https://togithub.com/JLHwung)) ##### :memo: Documentation - [#​16319](https://togithub.com/babel/babel/pull/16319) Update SECURITY.md ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) ##### :house: Internal - `babel-code-frame`, `babel-highlight` - [#​16359](https://togithub.com/babel/babel/pull/16359) Replace `chalk` with `picocolors` ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - `babel-helper-fixtures`, `babel-helpers`, `babel-plugin-bugfix-safari-id-destructuring-collision-in-function-expression`, `babel-plugin-proposal-pipeline-operator`, `babel-plugin-transform-unicode-sets-regex`, `babel-preset-env`, `babel-preset-flow` - [#​16352](https://togithub.com/babel/babel/pull/16352) Run Babel transform tests on old node if possible ([@​JLHwung](https://togithub.com/JLHwung)) - `babel-helpers`, `babel-plugin-transform-async-generator-functions`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-class-static-block`, `babel-plugin-transform-modules-commonjs`, `babel-plugin-transform-modules-systemjs`, `babel-plugin-transform-regenerator`, `babel-plugin-transform-runtime`, `babel-preset-env`, `babel-runtime-corejs3`, `babel-runtime`, `babel-standalone` - [#​16323](https://togithub.com/babel/babel/pull/16323) Allow separate helpers to be excluded in Babel 8 ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu)) - `babel-helper-module-imports`, `babel-plugin-proposal-import-wasm-source`, `babel-plugin-proposal-json-modules`, `babel-plugin-proposal-record-and-tuple`, `babel-plugin-transform-react-jsx-development`, `babel-plugin-transform-react-jsx` - [#​16349](https://togithub.com/babel/babel/pull/16349) Support merging imports in import injector ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-plugin-bugfix-safari-id-destructuring-collision-in-function-expression`, `babel-plugin-bugfix-v8-spread-parameters-in-optional-chaining`, `babel-plugin-bugfix-v8-static-class-fields-redefine-readonly`, `babel-plugin-external-helpers`, `babel-plugin-proposal-async-do-expressions`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-destructuring-private`, `babel-plugin-proposal-do-expressions`, `babel-plugin-proposal-duplicate-named-capturing-groups-regex`, `babel-plugin-proposal-explicit-resource-management`, `babel-plugin-proposal-export-default-from`, `babel-plugin-proposal-function-bind`, `babel-plugin-proposal-function-sent`, `babel-plugin-proposal-import-attributes-to-assertions`, `babel-plugin-proposal-import-defer`, `babel-plugin-proposal-import-wasm-source`, `babel-plugin-proposal-json-modules`, `babel-plugin-proposal-optional-chaining-assign`, `babel-plugin-proposal-partial-application`, `babel-plugin-proposal-pipeline-operator`, `babel-plugin-proposal-record-and-tuple`, `babel-plugin-proposal-regexp-modifiers`, `babel-plugin-proposal-throw-expressions`, `babel-plugin-syntax-async-do-expressions`, `babel-plugin-syntax-decimal`, `babel-plugin-syntax-decorators`, `babel-plugin-syntax-destructuring-private`, `babel-plugin-syntax-do-expressions`, `babel-plugin-syntax-explicit-resource-management`, `babel-plugin-syntax-export-default-from`, `babel-plugin-syntax-flow`, `babel-plugin-syntax-function-bind`, `babel-plugin-syntax-function-sent`, `babel-plugin-syntax-import-assertions`, `babel-plugin-syntax-import-attributes`, `babel-plugin-syntax-import-defer`, `babel-plugin-syntax-import-reflection`, `babel-plugin-syntax-import-source`, `babel-plugin-syntax-jsx`, `babel-plugin-syntax-module-blocks`, `babel-plugin-syntax-optional-chaining-assign`, `babel-plugin-syntax-partial-application`, `babel-plugin-syntax-pipeline-operator`, `babel-plugin-syntax-record-and-tuple`, `babel-plugin-syntax-throw-expressions`, `babel-plugin-syntax-typescript`, `babel-plugin-transform-arrow-functions`, `babel-plugin-transform-async-generator-functions`, `babel-plugin-transform-async-to-generator`, `babel-plugin-transform-block-scoped-functions`, `babel-plugin-transform-block-scoping`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-class-static-block`, `babel-plugin-transform-classes`, `babel-plugin-transform-computed-properties`, `babel-plugin-transform-destructuring`, `babel-plugin-transform-dotall-regex`, `babel-plugin-transform-duplicate-keys`, `babel-plugin-transform-dynamic-import`, `babel-plugin-transform-exponentiation-operator`, `babel-plugin-transform-export-namespace-from`, `babel-plugin-transform-flow-comments`, `babel-plugin-transform-flow-strip-types`, `babel-plugin-transform-for-of`, `babel-plugin-transform-function-name`, `babel-plugin-transform-instanceof`, `babel-plugin-transform-jscript`, `babel-plugin-transform-json-strings`, `babel-plugin-transform-literals`, `babel-plugin-transform-logical-assignment-operators`, `babel-plugin-transform-member-expression-literals`, `babel-plugin-transform-modules-amd`, `babel-plugin-transform-modules-commonjs`, `babel-plugin-transform-modules-systemjs`, `babel-plugin-transform-modules-umd`, `babel-plugin-transform-new-target`, `babel-plugin-transform-nullish-coalescing-operator`, `babel-plugin-transform-numeric-separator`, `babel-plugin-transform-object-assign`, `babel-plugin-transform-object-rest-spread`, `babel-plugin-transform-object-set-prototype-of-to-assign`, `babel-plugin-transform-object-super`, `babel-plugin-transform-optional-catch-binding`, `babel-plugin-transform-optional-chaining`, `babel-plugin-transform-parameters`, `babel-plugin-transform-private-methods`, `babel-plugin-transform-private-property-in-object`, `babel-plugin-transform-property-literals`, `babel-plugin-transform-property-mutators`, `babel-plugin-transform-proto-to-assign`, `babel-plugin-transform-react-constant-elements`, `babel-plugin-transform-react-display-name`, `babel-plugin-transform-react-inline-elements`, `babel-plugin-transform-react-jsx-compat`, `babel-plugin-transform-react-jsx-self`, `babel-plugin-transform-react-jsx-source`, `babel-plugin-transform-react-pure-annotations`, `babel-plugin-transform-regenerator`, `babel-plugin-transform-reserved-words`, `babel-plugin-transform-runtime`, `babel-plugin-transform-shorthand-properties`, `babel-plugin-transform-spread`, `babel-plugin-transform-sticky-regex`, `babel-plugin-transform-strict-mode`, `babel-plugin-transform-template-literals`, `babel-plugin-transform-typeof-symbol`, `babel-plugin-transform-typescript`, `babel-plugin-transform-unicode-escapes`, `babel-plugin-transform-unicode-property-regex`, `babel-plugin-transform-unicode-regex`, `babel-plugin-transform-unicode-sets-regex`, `babel-preset-env`, `babel-preset-flow`, `babel-preset-react`, `babel-preset-typescript` - [#​16332](https://togithub.com/babel/babel/pull/16332) Test Babel 7 plugins compatibility with Babel 8 core ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - `babel-compat-data`, `babel-plugin-transform-object-rest-spread`, `babel-preset-env` - [#​16318](https://togithub.com/babel/babel/pull/16318) \[babel 8] Fix `@babel/compat-data` package.json ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) ##### :microscope: Output optimization - `babel-helper-replace-supers`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-classes`, `babel-plugin-transform-parameters`, `babel-plugin-transform-runtime` - [#​16345](https://togithub.com/babel/babel/pull/16345) Optimize the use of `assertThisInitialized` after `super()` ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu)) - `babel-plugin-transform-class-properties`, `babel-plugin-transform-classes` - [#​16343](https://togithub.com/babel/babel/pull/16343) Use simpler `assertThisInitialized` more often ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu)) - `babel-plugin-proposal-decorators`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-object-rest-spread`, `babel-traverse` - [#​16342](https://togithub.com/babel/babel/pull/16342) Consider well-known and registered symbols as literals ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - `babel-core`, `babel-plugin-external-helpers`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-function-bind`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-classes`, `babel-plugin-transform-flow-comments`, `babel-plugin-transform-flow-strip-types`, `babel-plugin-transform-function-name`, `babel-plugin-transform-modules-systemjs`, `babel-plugin-transform-parameters`, `babel-plugin-transform-private-property-in-object`, `babel-plugin-transform-react-jsx`, `babel-plugin-transform-runtime`, `babel-plugin-transform-spread`, `babel-plugin-transform-typescript`, `babel-preset-env` - [#​16326](https://togithub.com/babel/babel/pull/16326) Reduce the use of class names ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu)) ### [`v7.24.0`](https://togithub.com/babel/babel/blob/HEAD/CHANGELOG.md#v7240-2024-02-28) [Compare Source](https://togithub.com/babel/babel/compare/v7.23.9...v7.24.0) ##### :rocket: New Feature - `babel-standalone` - [#​11696](https://togithub.com/babel/babel/pull/11696) Export babel tooling packages in `@babel/standalone` ([@​ajihyf](https://togithub.com/ajihyf)) - `babel-core`, `babel-helper-create-class-features-plugin`, `babel-helpers`, `babel-plugin-transform-class-properties` - [#​16267](https://togithub.com/babel/babel/pull/16267) Implement `noUninitializedPrivateFieldAccess` assumption ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-helpers`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-pipeline-operator`, `babel-plugin-syntax-decorators`, `babel-plugin-transform-class-properties`, `babel-runtime-corejs2`, `babel-runtime-corejs3`, `babel-runtime` - [#​16242](https://togithub.com/babel/babel/pull/16242) Support decorator 2023-11 normative updates ([@​JLHwung](https://togithub.com/JLHwung)) - `babel-preset-flow` - [#​16309](https://togithub.com/babel/babel/pull/16309) \[babel 7] Allow setting `ignoreExtensions` in Flow preset ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - [#​16284](https://togithub.com/babel/babel/pull/16284) Add `experimental_useHermesParser` option in `preset-flow` ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu)) - `babel-helper-import-to-platform-api`, `babel-plugin-proposal-import-wasm-source`, `babel-plugin-proposal-json-modules`, `babel-standalone` - [#​16172](https://togithub.com/babel/babel/pull/16172) Add transform support for JSON modules imports ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - `babel-plugin-transform-runtime` - [#​16241](https://togithub.com/babel/babel/pull/16241) Add back `moduleName` option to `@babel/plugin-transform-runtime` ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - `babel-parser`, `babel-types` - [#​16277](https://togithub.com/babel/babel/pull/16277) Allow import attributes for `TSImportType` ([@​sosukesuzuki](https://togithub.com/sosukesuzuki)) ##### :bug: Bug Fix - `babel-plugin-proposal-do-expressions`, `babel-traverse` - [#​16305](https://togithub.com/babel/babel/pull/16305) fix: avoid `popContext` on unvisited node paths ([@​JLHwung](https://togithub.com/JLHwung)) - `babel-helper-create-class-features-plugin`, `babel-plugin-transform-private-methods`, `babel-plugin-transform-private-property-in-object` - [#​16312](https://togithub.com/babel/babel/pull/16312) Fix class private properties when `privateFieldsAsSymbols` ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-plugin-transform-private-methods` - [#​16307](https://togithub.com/babel/babel/pull/16307) Fix the support of `arguments` in private `get/set` method ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-helpers`, `babel-plugin-proposal-decorators` - [#​16287](https://togithub.com/babel/babel/pull/16287) Reduce decorator static property size ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators` - [#​16281](https://togithub.com/babel/babel/pull/16281) Fix evaluation order of decorators with cached receiver ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - [#​16279](https://togithub.com/babel/babel/pull/16279) Fix decorator this memoization ([@​JLHwung](https://togithub.com/JLHwung)) - [#​16266](https://togithub.com/babel/babel/pull/16266) Preserve `static` on decorated private `accessor` ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - [#​16258](https://togithub.com/babel/babel/pull/16258) fix: handle decorated async private method and generator ([@​JLHwung](https://togithub.com/JLHwung)) - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators`, `babel-plugin-transform-async-generator-functions`, `babel-plugin-transform-private-methods`, `babel-plugin-transform-private-property-in-object`, `babel-plugin-transform-typescript`, `babel-preset-env` - [#​16275](https://togithub.com/babel/babel/pull/16275) Fix class private properties when `privateFieldsAsProperties` ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu)) - `babel-helpers` - [#​16268](https://togithub.com/babel/babel/pull/16268) Do not consider `arguments` in a helper as a global reference ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - `babel-helpers`, `babel-plugin-proposal-decorators` - [#​16270](https://togithub.com/babel/babel/pull/16270) Handle symbol key class elements decoration ([@​JLHwung](https://togithub.com/JLHwung)) - [#​16265](https://togithub.com/babel/babel/pull/16265) Do not define `access.get` for public setter decorators ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) ##### :nail_care: Polish - `babel-core`, `babel-helper-create-class-features-plugin`, `babel-preset-env` - [#​12428](https://togithub.com/babel/babel/pull/12428) Suggest using `BABEL_SHOW_CONFIG_FOR` for config problems ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) ##### :house: Internal - `babel-helper-transform-fixture-test-runner` - [#​16278](https://togithub.com/babel/babel/pull/16278) Continue writing `output.js` when `exec.js` throws ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu)) ##### :microscope: Output optimization - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators` - [#​16306](https://togithub.com/babel/babel/pull/16306) Avoid intermediate functions for private accessors with decs ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-helpers`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-pipeline-operator`, `babel-plugin-transform-class-properties` - [#​16294](https://togithub.com/babel/babel/pull/16294) More aggressively inline decorators in the static block ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-helpers`, `babel-plugin-transform-private-methods` - [#​16283](https://togithub.com/babel/babel/pull/16283) Do not use `classPrivateMethodGet` ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-helpers`, `babel-plugin-proposal-decorators` - [#​16287](https://togithub.com/babel/babel/pull/16287) Reduce decorator static property size ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators`, `babel-plugin-transform-class-properties` - [#​16280](https://togithub.com/babel/babel/pull/16280) Reduce element decorator temp variables ([@​JLHwung](https://togithub.com/JLHwung)) - `babel-helper-create-class-features-plugin`, `babel-helper-fixtures`, `babel-helpers`, `babel-plugin-bugfix-v8-spread-parameters-in-optional-chaining`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-destructuring-private`, `babel-plugin-proposal-optional-chaining-assign`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-class-static-block`, `babel-plugin-transform-private-methods`, `babel-plugin-transform-private-property-in-object`, `babel-preset-env`, `babel-runtime-corejs2`, `babel-runtime-corejs3`, `babel-runtime` - [#​16261](https://togithub.com/babel/babel/pull/16261) Do not use descriptors for private class elements ([@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo)) - `babel-helpers`, `babel-plugin-proposal-decorators` - [#​16263](https://togithub.com/babel/babel/pull/16263) Reduce helper size for decorator 2023-11 ([@​liuxingbaoyu](https://togithub.com/liuxingbaoyu))

Configuration

📅 Schedule: Branch creation - "before 3am on the first day of the month" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

This PR has been generated by Mend Renovate. View repository job log here.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: bae0ebc61b12a2bf94ee50c882e3e9ff17b8b173

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs 🛑 Canceled (Inspect) Apr 5, 2024 9:27am
marigold-storybook 🛑 Canceled (Inspect) Apr 5, 2024 9:27am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **marigold-production** | ⬜️ Ignored ([Inspect](https://vercel.com/marigold/marigold-production/Bjp7znH8rd17Mpe6wPZaJFkb79Vk)) | [Visit Preview](https://marigold-production-git-renovate-babel-monorepo-marigold.vercel.app) | | Apr 5, 2024 9:27am |
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.57%. Comparing base (17baa24) to head (734a839). Report is 1 commits behind head on main.

:exclamation: Current head 734a839 differs from pull request most recent head bae0ebc. Consider uploading reports for the commit bae0ebc to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/marigold-ui/marigold/pull/3855/graphs/tree.svg?width=650&height=150&src=pr&token=YIIcKX7TZu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)](https://app.codecov.io/gh/marigold-ui/marigold/pull/3855?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) ```diff @@ Coverage Diff @@ ## main #3855 +/- ## ========================================== - Coverage 99.83% 99.57% -0.26% ========================================== Files 122 122 Lines 6557 6557 Branches 328 318 -10 ========================================== - Hits 6546 6529 -17 - Misses 10 27 +17 Partials 1 1 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/marigold-ui/marigold/pull/3855/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)
renovate[bot] commented 1 month ago

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.