Open OsamaAbdellateef opened 4 weeks ago
vercel[bot]
commented
4 weeks ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| marigold-docs | 🛑 Canceled (Inspect) | Apr 30, 2024 10:44am | ||
| marigold-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 30, 2024 10:44am |
sebald
commented
1 week ago LGTM just one question: with this implementation, people can not deeplink (with a certain theme). Should we add this or leave it?
@sarahgm @OsamaAbdellateef @aromko @KadaStrophe
OsamaAbdellateef
commented
1 week ago LGTM just one question: with this implementation, people can not deeplink (with a certain theme). Should we add this or leave it?
@sarahgm @OsamaAbdellateef @aromko @KadaStrophe
you mean when you have a deep link and then switch the theme u lose the deep link ? @sebald
sebald
commented
1 week ago LGTM just one question: with this implementation, people can not deeplink (with a certain theme). Should we add this or leave it? @sarahgm @OsamaAbdellateef @aromko @KadaStrophe
you mean when you have a deep link and then switch the theme u lose the deep link ? @sebald
Yes :) like always having the ?theme=core query appended
OsamaAbdellateef
commented
1 week ago LGTM just one question: with this implementation, people can not deeplink (with a certain theme). Should we add this or leave it? @sarahgm @OsamaAbdellateef @aromko @KadaStrophe
you mean when you have a deep link and then switch the theme u lose the deep link ? @sebald
Yes :) like always having the
?theme=corequery appended
For me i would say it is good to have
OsamaAbdellateef
commented
1 week ago LGTM just one question: with this implementation, people can not deeplink (with a certain theme). Should we add this or leave it? @sarahgm @OsamaAbdellateef @aromko @KadaStrophe
you mean when you have a deep link and then switch the theme u lose the deep link ? @sebald
Yes :) like always having the
?theme=corequery appended
done :heavy_check_mark: @sebald
🦋 Changeset detected
Latest commit: 9101b030a59e1f1e1496b804c81047cf06b2bf3e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
| Name | Type | | -------------------------- | ----- | | @marigold/docs | Patch | | @marigold/system | Patch | | @marigold/components | Patch | | @marigold/icons | Patch | | @marigold/theme-preset | Patch | | @marigold/theme-b2b | Patch | | @marigold/theme-core | Patch | | @marigold/storybook-config | Patch |Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR