marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

docs: improve page layout #3884

Closed sebald closed 1 week ago

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: fa3918fafdb30b89a610c9dc8aab410f4f3901e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 7:12pm
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 7:12pm
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **marigold-production** | ⬜️ Ignored ([Inspect](https://vercel.com/marigold/marigold-production/5si9dgesPgFstNFm5QoowTU2QJsu)) | [Visit Preview](https://marigold-production-git-refa-page-layout-marigold.vercel.app) | | Apr 25, 2024 7:12pm |
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.58%. Comparing base (8e6bfeb) to head (e4f22cf). Report is 6 commits behind head on main.

:exclamation: Current head e4f22cf differs from pull request most recent head fa3918f. Consider uploading reports for the commit fa3918f to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/marigold-ui/marigold/pull/3884/graphs/tree.svg?width=650&height=150&src=pr&token=YIIcKX7TZu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)](https://app.codecov.io/gh/marigold-ui/marigold/pull/3884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) ```diff @@ Coverage Diff @@ ## main #3884 +/- ## ========================================== - Coverage 99.64% 99.58% -0.06% ========================================== Files 125 125 Lines 6670 6672 +2 Branches 326 323 -3 ========================================== - Hits 6646 6644 -2 - Misses 23 27 +4 Partials 1 1 ``` | [Files](https://app.codecov.io/gh/marigold-ui/marigold/pull/3884?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui) | Coverage Δ | | |---|---|---| | [packages/components/src/Text/Text.tsx](https://app.codecov.io/gh/marigold-ui/marigold/pull/3884?src=pr&el=tree&filepath=packages%2Fcomponents%2Fsrc%2FText%2FText.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui#diff-cGFja2FnZXMvY29tcG9uZW50cy9zcmMvVGV4dC9UZXh0LnRzeA==) | `100.00% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/marigold-ui/marigold/pull/3884/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marigold-ui)
sebald commented 1 week ago

I think we slightly need to optimize the mobile view (less px)

fixed :D