search

marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

refa(theme): update theme structure and adjust components #906

Closed viktoria-schwarz closed 3 years ago

viktoria-schwarz commented 3 years ago

905 and closes #862

Still missing:

changeset-bot[bot] commented 3 years ago

⚠️ No Changeset found

Latest commit: 5eaf91c47f3849f8657973913fd912e32e664902

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 5eaf91c47f3849f8657973913fd912e32e664902 on refa-theme into deb7d100ad03068b8729b237879b8507775cbbcc on main.

ti10le commented 3 years ago

@sebald do you want to have a look at this before merging?

sebald commented 3 years ago

Jep will take a look later :)

sebald commented 3 years ago

@viktoria-schwarz @ti10le have two comments but nothing big. Just merge it.

Also, since we updated ˋtheme-uiˋ we can use __default. See here for more info: https://github.com/system-ui/theme-ui/blob/develop/CHANGELOG.md#v060

sebald commented 3 years ago

@ti10le die Änderung macht die column kaputt oder 🤔

viktoria-schwarz commented 3 years ago

Also, since we updated ˋtheme-uiˋ we can use __default. See here for more info: system-ui/theme-ui@develop/CHANGELOG.md#v060

Where should we use it? This should be an extra issue though

sebald commented 3 years ago

Where should we use it? This should be an extra issue though

@viktoria-schwarz yeah, we have to make a plan how to use it first 😉

ti10le commented 3 years ago

@ti10le die Änderung macht die column kaputt oder 🤔

Soweit ich das sehen konnte nicht. Sieht noch gut aus in dem Branch

sebald commented 3 years ago

Soweit ich das sehen konnte nicht. Sieht noch gut aus in dem Branch

@ti10le Ah, weil man einfach ne number nehmen kann, aber das sollte ja eigentlich von theme.space sein. Das sind jetzt strings keine Zahlen mehr.

ti10le commented 3 years ago

Soweit ich das sehen konnte nicht. Sieht noch gut aus in dem Branch

@ti10le Ah, weil man einfach ne number nehmen kann, aber das sollte ja eigentlich von theme.space sein. Das sind jetzt strings keine Zahlen mehr.

Ja genau das sollte dann irgendwann auch noch angepasst werden.