marigold-ui / marigold

Design System based on react-aria and Tailwind CSS
https://marigold-ui.io
MIT License
101 stars 7 forks source link

Add design tokens pages to Gatsby Marigold docs #940

Closed ti10le closed 2 years ago

ti10le commented 3 years ago

Description

After #925 is closed we have to move the existing markdown pages from navigation point: design Tokens to the gatsby project. Update documentation pages and description together with UX/UI.

Context

Next step to fill the gatsby marigold docs page. Complete the components navigation point.

sebald commented 3 years ago

How does this work with themes? They might have different tokens 🤔

viktoria-schwarz commented 3 years ago

How to approach this? Keep the design tokens description very minimalistic and general, or include it in the Theme descriptions of each new theme?

ti10le commented 3 years ago

Correct it depends on the theme. I don't thought about that.

sebald commented 3 years ago

Macht es alternativ dann vllt sein eine Seite (mit allen Tokens) pro Theme zu haben?

viktoria-schwarz commented 3 years ago

That's what I meant in my second proposal :)

ti10le commented 3 years ago

This is a good approach 👍🏼

in gatsby page:

In our repo:

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

ti10le commented 2 years ago

@sebald @viktoria-schwarz Do we implement that Design Tokens like Colors or icons changes after select another theme? At the moment it's the same for all.

ti10le commented 2 years ago

@sebald @viktoria-schwarz :) ?

sebald commented 2 years ago

Close until it's necessary. We're not doing this in the foreseeable future.