search

marijnh / Eloquent-JavaScript

The sources for the Eloquent JavaScript book
https://eloquentjavascript.net
3.02k stars 796 forks source link

Remove unnecessary duplicating/paraphrasing sentence #506

Closed RiseOoi closed 4 years ago

RiseOoi commented 4 years ago

This sentence is confusing the first time I read it, cost me 1 minute to understand:

This feature—being able to reference a specific instance of a local binding in an enclosing scope—is called ((closure)). A function that references bindings from local scopes around it is called a closure.

Because it explains closure twice.

PR removes the second sentence.

marijnh commented 4 years ago

The first sentence describes the feature called "closure", the second that a function that uses this feature is called "a closure". These are two different usages of the term, and I'm keeping that second sentence.

RiseOoi commented 4 years ago

I see, I understand now.

Not sure if it confuses other people too, but if so, may need revision.

pelx commented 4 years ago

Hi Marijhn, it took me a bit to understand this too, but this is a complex subject. I take this opportunity to thank you. Your book is very dense and difficult but I like your style. I am sick and tired from online courses that only scratch a surface. kind regards laura On Thursday, 28 November 2019, 06:51:42 GMT, Marijn Haverbeke notifications@github.com wrote:

Closed #506.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.