marijnh / Postmodern

A Common Lisp PostgreSQL programming interface
http://marijnhaverbeke.nl/postmodern
Other
400 stars 90 forks source link

Fix: add missing closing parentheses #349

Closed kilianmh closed 6 months ago

kilianmh commented 6 months ago

Now the compilation of the test suite works again. Still many tests do not succeed.

sabracrolleton commented 6 months ago

You have put the closing paren in the wrong place. It needs to be after :preserve-rows.

     (is (equal (sql (:create-extended-table (:temporary distributors)
                          :as
                          (:select '*
                        :from 'businesses
                        :where (:= 'type "distribution"))
                          ((:on-commit :preserve-rows))))
                 "CREATE TEMP TABLE distributors ON COMMIT PRESERVE ROWS AS ((SELECT * FROM businesses WHERE (type =          E'distribution')))"))
kilianmh commented 6 months ago

Now it should be correct

sabracrolleton commented 6 months ago

Are the tests now passing on your side?

sabracrolleton commented 6 months ago

They are passing for me.