search

marilari88 / neotest-vitest

Vitest adapter for Neovim Neotest plugin
106 stars 33 forks source link

📝 Improve lazy.nvim install syntax #49

Closed joshmedeski closed 6 months ago

joshmedeski commented 6 months ago

I have been having difficulty getting neotest-vitest to work nicely with LazyVim.

After much experimentation, what I'm proposing in this PR works and ensures other adaptors configured separately (like neotest-go) work as well.

Hopefully this helps someone else, if I set what was mentioned in the README right now broke my other adaptor configurations.

marilari88 commented 6 months ago

Hi @joshmedeski, Thank you for your contribution! have you tried using your config outside of lazyvim? Replacing the config key with opts doesn't seem to be working well for me. Before merging I want to be sure the config fit all lazy.nvim installations

joshmedeski commented 6 months ago

Thanks for calling this out. Been busy with work so I'll be sure to look at this and get back to you this week.

joshmedeski commented 6 months ago

Okay after some testing I can confirm this doesn't work outside Lazyvim like you described.

However, in Lazyvim the current lazy.nvim example doesn't work. So there might be some confusion for people that are setting up or extending Neotest in some other way (through a distro, or on their own somehow).

So just something to keep in mind if any issues pop up.

joshmedeski commented 6 months ago

If you want more context for how LazyVim sets up Neotest you can view the code here: https://github.com/LazyVim/LazyVim/blob/5646ee5191da244ff8ea57b9dba8a7e0d1dbdd42/lua/lazyvim/plugins/extras/test/core.lua?plain=1#L12

marilari88 commented 6 months ago

Hey @joshmedeski, I believe we need to include specific instructions for both LazyVim and lazy.nvim until we have a configuration that seamlessly accommodates both. While LazyVim is based on lazy.nvim, duplicating the same config logic of the file you linked above doesn't seem practical to me. I've updated the README with a corresponding commit. Please tell me if it is ok for you

joshmedeski commented 6 months ago

Yeah that makes sense, thanks for the update.

marilari88 commented 6 months ago

Thank you @joshmedeski! Also, thank for your videos! They are very inspiring

joshmedeski commented 6 months ago

You're welcome, thanks for this plugin. I use it every day at work!