marilari88 / neotest-vitest

Vitest adapter for Neovim Neotest plugin
92 stars 34 forks source link

feat: support nested describe #55

Closed AbaoFromCUG closed 4 weeks ago

AbaoFromCUG commented 2 months ago

Features

Fix

marilari88 commented 2 months ago

hi @AbaoFromCUG @joshmedeski Thanks for your huge contribution! Feel free to you take a look at the actions that are failing? in other case I will do as soon as I can

AbaoFromCUG commented 2 months ago

I had removed vim.iter in init.lua because it is new feature of neovim 0.10

joshmedeski commented 2 months ago

Hey @AbaoFromCUG can you clarify why I'm authored on this commit? I don't remember helping you write any of this code. Maybe it was indirect and I'm missing something.

If this was done by mistake can you remove me from the commit?

AbaoFromCUG commented 2 months ago

@joshmedeski I am sorry to bother you, I guess that the maintainer @marilari88 add you to reviewer.

joshmedeski commented 2 months ago

Just to confirm, it says I authored the commit, but I did not. Please check your git config or change the git commit message on this PR so that you are the only author, thanks.

marilari88 commented 1 month ago

@AbaoFromCUG ping

GitMurf commented 1 month ago

Any updates here? Very excited for these changes and fixes!! Thanks!

AbaoFromCUG commented 1 month ago

@marilari88

I have revert the modify about testNamePattern single quote issue and resolve the comment.

I test in 3 type configuration manually, and all test cases are passed

1. Plain Config

    require("neotest").setup({
        adapters = {
            require("neotest-vitest")({
                vitestCommand = "bunx vitest",
            }),
        }
    })

2. Your nvim lua config

from https://github.com/marilari88/nvim-lua-config

    require("neotest").setup({
        adapters = {
            require("neotest-vitest")({
                vitestCommand = "bunx vitest",
            }),
        },
        quickfix = { open = true },
        output = {
            enabled = true,
            open = "botright split | resize 15",
        }
    })

3. My config

neotest+neotest-vitest+overseer.nvim+"toggleterm.nvim`

     require("overseer").setup({
        templates = { "builtin" },
        strategy = {
            "toggleterm",
            direction = "float",
            use_shell = true,
        },
    })
    ---@diagnostic disable-next-line: duplicate-set-field
    require("overseer.shell").escape_cmd = function(cmd)
        return table.concat(vim.tbl_map(vim.fn.shellescape, cmd), " ")
    end
    require("neotest").setup({
        adapters = {
            require("neotest-vitest")({
                vitestCommand = "bunx vitest",
            }),
        },
        consumers = { overseer = require("neotest.consumers.overseer") },
    })

Could you checkout and test it? thanks

AbaoFromCUG commented 1 month ago

@marilari88 fix v0.9.5 compatible issue

GitMurf commented 4 weeks ago

This is awesome!! Thanks so much for this PR! Quick question to confirm, this does NOT resolve the it.each() dynamic parameterized names issue correct?

AbaoFromCUG commented 4 weeks ago

This is awesome!! Thanks so much for this PR! Quick question to confirm, this does NOT resolve the it.each() dynamic parameterized names issue correct?

No.

Don't related to it.each()/test.each()