fix: marimo home directory shouldn't be in sys.path

marimo-team / marimo

A reactive notebook for Python — run reproducible experiments, execute as a script, deploy as an app, and version with git.

https://marimo.io

Apache License 2.0

5.35k stars 156 forks source link

fix: marimo home directory shouldn't be in sys.path #1618

Closed akshayka closed 2 weeks ago

akshayka commented 2 weeks ago

This change fixes a bug in which the directory in which marimo home was started (when using marimo edit) was incorrectly added to sys.path even when working in a notebook in a subdirectory. This led to modules being importable that shouldn't have been importable.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
marimo-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 13, 2024 6:10pm
marimo-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 13, 2024 6:10pm

akshayka commented 2 weeks ago

could this technically be breaking for some users?

maybe ... but I count it as a bug not a feature. no one should have been relying on it because the behavior was bizarre

github-actions[bot] commented 2 weeks ago

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.6.20-dev1