search

marimo-team / marimo

A reactive notebook for Python — run reproducible experiments, execute as a script, deploy as an app, and version with git.
https://marimo.io
Apache License 2.0
5.35k stars 156 forks source link

fix: uninstantiated logic #1632

Closed akshayka closed 2 weeks ago

akshayka commented 2 weeks ago

This change fixes a bug in which cells were incorrectly marked as stale on session startup/resume.

Previously, the frontend set a cell's staleInputs to true if autorun-on-startup was disabled or if a cell didn't have an execution time. But errored cells don't have execution times. And in general, setting staleInputs is error-prone and only something the BE can determine.

This change instead initializes with staleInputs=False, letting session replay override it as usual, and makes the check for whether a cell is uninstantiated more robust.

Tested by manually playing around with a lot of edge cases.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 10:58pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 10:58pm
github-actions[bot] commented 2 weeks ago

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.6.20-dev11