search

marimo-team / marimo

A reactive notebook for Python — run reproducible experiments, execute as a script, deploy as an app, and version with git.
https://marimo.io
Apache License 2.0
5.31k stars 155 forks source link

fix: robust websocket disconnect, nonblocking usage stats #1655

Closed akshayka closed 1 week ago

akshayka commented 1 week ago

  1. When multiple notebooks are open in marimo edit, we sometimes get unexpected WebSocketDisconnects. This change makes the server more robust to those errors — one can at least continue working with notebooks that failed to connect by refreshing —  without solving the root problem.

  2. Make usage endpoint's CPU measurement nonblocking. This was slowing down the server.

Fixes #1653 Fixes #1622

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 1:17am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 1:17am
mscolnick commented 1 week ago

can we wait till https://github.com/marimo-team/marimo/pull/1639 merges? it will simplify this and otherwise cause a few merge conflicts nvm not too overlapping