Add support for `np.ndarray` class of ArviZ package to show plots - Githubissues

marimo-team / marimo

A reactive notebook for Python — run reproducible experiments, execute as a script, deploy as an app, and version with git.

https://marimo.io

Apache License 2.0

5.31k stars 155 forks source link

Add support for `np.ndarray` class of ArviZ package to show plots #1668

Open Haleshot opened 1 week ago

Haleshot commented 1 week ago

📝 Summary

This PR addresses issue #1033 by implementing an ArviZ formatter that can handle various plot types returned by ArviZ functions, including numpy arrays, matplotlib axes, and bokeh figures.

🔍 Description of Changes

Created a new NpndarrayFormatter class that extends FormatterFactory
Implemented a _show_npndarray_plot function that handles the return types which causes the issue from ArviZ plots:
- numpy arrays (more specifically np.ndarrays).

📋 Checklist

[x] I have read the contributor guidelines.
[ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
[ ] I have added tests for the changes made.
[x] I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
marimo-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 24, 2024 9:20am
marimo-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 24, 2024 9:20am