search

marimo-team / marimo

A reactive notebook for Python — run reproducible experiments, execute as a script, deploy as an app, and version with git.
https://marimo.io
Apache License 2.0
5.31k stars 155 forks source link

fix: strict execution single cell reference error #1686

Closed dmadisetti closed 4 days ago

dmadisetti commented 4 days ago

📝 Summary

fix: If a cell references a variable that no other cell potentially produces, strict mode is supposed to create an error.

🔍 Description of Changes

A small bug in transitive_references (dataflow.py) stopped the expected behavior from happening, but then I realized the error UI was slightly wrong (MarimoErrorOutput.tsx, cell_runner.py, errors.py).

So, I added a unit test (test_runtime.py), and realized that Strict Errors should probably be promoted to kernel level errors (runtime.py).

📜 Reviewers

Your PR will be reviewed more quickly if you can figure out the right person to tag with @ --> @akshayka OR @mscolnick

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 10:35pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 10:35pm
github-actions[bot] commented 4 days ago

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.6.24-dev3