marimo-team / marimo

A reactive notebook for Python — run reproducible experiments, execute as a script, deploy as an app, and version with git.
https://marimo.io
Apache License 2.0
8.13k stars 297 forks source link

Altair Charts fail to adapt to dark mode #2483

Open ngriffiths13 opened 2 months ago

ngriffiths13 commented 2 months ago

Describe the bug

When switched to dark mode, altair charts don't switch correctly. Instead the text disappears and only the chart lines are left.

Screenshot 2024-10-02 at 9 39 20 PM

Environment

{
  "marimo": "0.8.22",
  "OS": "Darwin",
  "OS Version": "23.2.0",
  "Processor": "arm",
  "Python Version": "3.11.9",
  "Binaries": {
    "Browser": "129.0.6668.72",
    "Node": "v22.6.0"
  },
  "Dependencies": {
    "click": "8.1.7",
    "importlib-resources": "6.4.5",
    "jedi": "0.19.1",
    "markdown": "3.7",
    "pygments": "2.18.0",
    "pymdown-extensions": "10.11.2",
    "ruff": "0.6.8",
    "starlette": "0.37.2",
    "tomlkit": "0.13.2",
    "typing-extensions": "4.12.2",
    "uvicorn": "0.29.0",
    "websockets": "12.0"
  },
  "Optional Dependencies": {
    "altair": "5.4.1",
    "pandas": "2.2.3",
    "polars": "1.9.0",
    "pyarrow": "17.0.0"
  }
}

Code to reproduce

No response

mscolnick commented 2 months ago

@ngriffiths13 - i cannot reproduce this. any chance you can include some code with a reproduction?

ngriffiths13 commented 2 months ago

@mscolnick I am struggling to reproduce it. In some notebooks I am seeing it works and in some it doesnt in the same environment. Working my way towards and MRE.

wasimsandhu commented 1 month ago

Busted!

Screenshot 2024-10-07 at 8 00 48 PM