search

marinaKollmitz / gazebo_ros_2Dmap_plugin

Gazebo simulator plugin to automatically generate a 2D occupancy map from the simulated world at a given height.
MIT License
96 stars 42 forks source link

Gazebo9 + Gazebo7 support #9

Closed ojasjoshi closed 4 years ago

ojasjoshi commented 4 years ago

I see that currently a separate branch exists for (melodic + gazebo9) support while the mainline supports (kinetic + gazebo7). Is there a plan to support gazebo7 and gazebo9 within the same branch?

For reference, I have made the changes in a personal fork. It would be great if these changes could be merged upstream in the mainline or as a separate branch.

marinaKollmitz commented 4 years ago

Hi, yes that is a good idea. I am planning to do a cleanup of the package very soon and will try to include the support for gazebo7 and gazebo9 there based on your fork. It would be great if you could help with the testing. Thank you!

ojasjoshi commented 4 years ago

Thanks for the positive response. Do you prefer me creating a PR into the mainline based on my fork?

ojasjoshi commented 4 years ago

hi @marinaKollmitz, created a PR #10. Can you take a look at the earliest convenience?

ojasjoshi commented 4 years ago

hi @marinaKollmitz, pinging for follow-up.

marinaKollmitz commented 4 years ago

I am receiving your messages and I will get to it as soon as I can. In the meantime, everyone who wants to can look at the PR and use your fork. Please be patient.

marinaKollmitz commented 4 years ago

10 solves this, thank you @ojasjoshi

ojasjoshi commented 4 years ago

Happy to contribute and thanks for taking a look this promptly!