Hide Icon has disappeared

mkkenya commented 4 years ago

We absolute love this plugin and more and more of our teachers have found a lot of value in it. Thanks for your hard work on this. Since the most recent update we have noticed the following

The hide icon and action for sections and subsections has completely disappeared. It was there in the previous version... in fact if we downgrade the version the hide action comes back.

marinaglancy commented 4 years ago

Hello ! The icon is definitely there but it has class="hide" or class="show" which may conflict with your theme that actually hides such elements. Can you please try to use the browser inspector and confirm that the icon is there but just not displayed?

At the same time it was not a good idea to use classes for different action types, I should have used the data- attributes

marinaglancy commented 4 years ago

Which theme do you use? Try to switch to Boost theme and check if the icon is displayed

mkkenya commented 4 years ago

We are using Boost theme

mkkenya commented 4 years ago

but also checked Clean theme as well

marinaglancy commented 4 years ago

what version of Moodle? Can you attach screenshot? Did you check inspector? The CSS can come from other plugins too, not just theme

mkkenya commented 4 years ago

When looking at the code we can see the action there... but cant click it, and cant see it

mkkenya commented 4 years ago

Moodle Version: 3.6 Cant Hide

marinaglancy commented 4 years ago

did you inspect the code? Do you see what causes the icon to disappear? This is my screenshot on vanilla Moodle 3.6 without any additional plugins: Screenshot 2020-05-11 at 16 15 18

marinaglancy commented 4 years ago

This is the diff between the latest version and the version before it https://github.com/marinaglancy/moodle-format_flexsections/compare/3.2.2...3.5.0

Among other changes I removed these styles:

/* Overwrite bootstrapbase styles */
.format-flexsections .course-content ul.flexsections .controls a.hide,
.format-flexsections .course-content ul.flexsections .controls a.show {display:inline;}

My reasoning was that bootstrapbase is no longer used and they are not needed (and my testing proved it). I guess, there is still something in your installation that overrides these classes

mkkenya commented 4 years ago

Thanks so much for your fast response - below is what I am seeing: Hide We have not added or updated anything but the plugin so I suspect something older in our installation like you mention... but I am not seeing what it could be (with my very limited knowledge sorry, I am a bit naïve in this, quite new. Which I know does not help you out much.)

mkkenya commented 4 years ago

So we know its there and functioning... just cant see it in course

marinaglancy commented 4 years ago

thanks for the report. Clearly some CSS conflict, I'm working on a patch

marinaglancy commented 4 years ago

preparing https://github.com/marinaglancy/moodle-format_flexsections/pull/15

marinaglancy commented 4 years ago

Fixed in version 3.5.1

marinaglancy / moodle-format_flexsections

Hide Icon has disappeared #14