search

marinaglancy / moodle-format_flexsections

25 stars 26 forks source link

Moodle has a style class .hide which is set to display: none #2

Closed gerryghall closed 6 years ago

gerryghall commented 10 years ago

and a overriding rule for the hide icon icon.hide display:in-line I have duplicated this so the hide/show action displays when the section is not hidden

marinaglancy commented 6 years ago

Hello, thanks for the suggestion. Some things in your patch were already fixed :

  1. There is already CSS for overriding bootstrap .hide class: https://github.com/marinaglancy/moodle-format_flexsections/blob/master/styles.css#L14
  2. sectionnum check is already present in lib.php https://github.com/marinaglancy/moodle-format_flexsections/blob/master/lib.php#L729

The "Collapsed" element on the general section is a valid request but your code formatting is very off so I'm going to re-write it and include in the next release.

gerryghall commented 6 years ago

wow that was like 3 or nearly 4 years ago.. :-)