marinasundstrom / YourBrand

Prototype enterprise system for e-commerce and consulting services
96 stars 14 forks source link

Migrate to Aspire #33

Open marinasundstrom opened 6 months ago

marinasundstrom commented 6 months ago

Might need to change the common extensions for OpenTelemetry and Logging.

marinasundstrom commented 6 months ago

There seems to be YARP support in the works: https://github.com/davidfowl/AspireYarp

marinasundstrom commented 5 months ago

Initial (WIP) is in: https://github.com/marinasundstrom/YourBrand/commit/975ed32370f26887524a46f75e298c71a8be7303

Remains work to clean up.

Includes removing old code for wiring up defaults in Program.cs.

Remove old service discovery:

if (builder.Environment.IsDevelopment())
{
    builder.Services.AddDiscoveryClient();
}

This can be removed.

builder.Services.AddObservability(ServiceName, ServiceVersion, builder.Configuration);

And this:

app.MapObservability();

Also remove the extension methods and references to NuGets.

marinasundstrom commented 5 months ago

In the future will use:

builder.AddServiceDefaults();

And:

app.MapDefaultEndpoints();

These are defined in the "YourBrand.ServiceDefaults" project.