marinasundstrom / yourbrand_new_old

Apache License 2.0
8 stars 1 forks source link

Improve HttpClients #25

Closed marinasundstrom closed 10 months ago

marinasundstrom commented 10 months ago
var catalogApiHttpClient = builder.Services.AddHttpClient("CatalogAPI", static (sp, http) =>
{
    var configuration = sp.GetRequiredService<IConfiguration>();
    http.BaseAddress = new Uri(configuration["yourbrand:catalog-svc:url"]!);
});

builder.Services.AddCatalogClients(builder.Configuration["yourbrand:catalog-svc:url"]!);

Could be:

builder.Services.AddCatalogClients(builder.Configuration["yourbrand:catalog-svc:url"]!, static (sp, http) =>
{
    var configuration = sp.GetRequiredService<IConfiguration>();
    http.BaseAddress = new Uri(configuration["yourbrand:catalog-svc:url"]!);
},
static (builder) => {
    catalogApiHttpClient.AddStandardResilienceHandler();

    if (builder.Environment.IsDevelopment())
    {
        catalogApiHttpClient.AddServiceDiscovery();
    }
});
marinasundstrom commented 10 months ago

Fixed