search

marinebon / obisindicators

R package for generating indicators from OBIS
https://marinebon.github.io/obisindicators/
Other
6 stars 4 forks source link

is gh-action pkgdown setup-r-deps needs:website needed? #33

Open 7yl4r opened 2 years ago

7yl4r commented 2 years ago

I am wondering what the following line from the pkgdown gh-action config does:

https://github.com/marinebon/obisindicators/blob/0df4cd8b926ea0352db800ffc33a7f11983610cd/.github/workflows/pkgdown.yaml#L29

Looking at the README for the relevant gh-action I think needs is supposed to specify a group of dependencies from the DESCRIPTION file. However: no website section exists in the DESCRIPTION.

If my assessment on this is correct then I would like to do the following:

  1. add a needed_to_build_the_website section to the DESCRIPTION which specifies pandoc as a website-build requirement
  2. rm the with:extra-packages:pandoc line from the gh-action.

I would like more R-experienced eyes on this before deleting that needs:website line though.