search

marinebon / obisindicators

R package for generating indicators from OBIS
https://marinebon.github.io/obisindicators/
Other
6 stars 4 forks source link

build failure `All topics must be included in reference index` #37

Open 7yl4r opened 2 years ago

7yl4r commented 2 years ago

Getting a build failure following merge of https://github.com/marinebon/obisindicators/pull/32

Error: Error: <callr_status_error: callr subprocess failed: All topics must be included in reference index

 x All topics must be included in reference index
• Missing topics: calc_indicators, gmap_indicator, occ_1960s, occ_1970s, occ_1980s, occ_1990s, occ_1M, occ_2000s, occ_2010s, occ_SAtlantic, occ_fk 
Execution halted
Error: Process completed with exit code 1.
7yl4r commented 2 years ago

This is just a temporary issue from the pkgdown dependency : https://github.com/r-lib/pkgdown/issues/2126 . It should be fixed once v2.0.4 is published to CRAN.

7yl4r commented 1 year ago

This same upstream issue is causing a different-looking build error:

Error in `check_missing_topics()`:
! All topics must be included in reference index
✖ Missing topics: make_hex_res
ℹ Either add to _pkgdown.yml or use @keyword internal
7yl4r commented 1 year ago

Actually, the error in my last comment seems to show has_concept working for all topics except h3::make_hex_res. I have copied in the @concept visualize just as was done on the other functions however. I cannot see what is wrong with it:

https://github.com/marinebon/obisindicators/blob/3aa53990d720c3cc4bd24912b6ee7aeef8f6176c/R/h3.R#L8

Can someone else take a look for what is wrong with the pkgdown docstring in R/h3.R? @bbest ? It is probably something dumb I am missing.

7yl4r commented 1 year ago

Issue is ongoing. I don't know why pkgdown isn't picking up the has_concept for h3::make_hex_res.