search

marinerhemant / MIDAS

The repository provides codes under the Microstructural Identification using Diffraction Analysis Software
http://marinerhemant.github.io/MIDAS/
Other
23 stars 10 forks source link

Discrepancy in Eta units in Result_StartNr_1_EndNr_1439.csv and Radius_StartNr_1_EndNr_1439.csv files #13

Open StopkaKris opened 2 months ago

StopkaKris commented 2 months ago

Hi Hemant,

The file Radius_StartNr_1_EndNr_1439.csv has a column entitled "Eta(degrees)" whereas the file Result_StartNr_1_EndNr_1439.csv (which I understand is a condensed version of the former file) has a column entitled "Eta(px)". The values in both files for this column appear to be the same so I think the units just need to be fixed in the latter file. The phrase "Eta(px)" is present in gui/imageManipulation.py, FF_HEDM/src/MergeOverlappingPeaksAll.c, and FF_HEDM/src/MergeOverlappingPeaksAllZarr.c.

Best regards, Kris

Krzysztof Stopka

StopkaKris commented 1 month ago

I have a follow up question regarding these files: I reconstructed the majority of my FF data at the end of May 2024 and I see that my Radius.csv files only go to 1439 instead of 1440, and accordingly, the Temp folder for each FF layer contains 1439 _PS.csv files. I reconstructed one of the data sets this week, did not change any parameters or MIDAS settings, and noticed that there are now 1440 files in the Temp folder and that the files mentioned above are now entitled Radius_StartNr_1_EndNr_1440.csv and Result_StartNr_1_EndNr_1440.csv. These files now correctly list data from omega of -180 to 179.75.

I updated my MIDAS installation on June 24 (I think), so I assume there was a debug update pushed to MIDAS around that time such that the final (1440th) frame in the .ge5 files is not ignored? If so, was this the only change that took place (as I am unsure whether it is worthwhile to reconstruct my data with the updated code that considers the additional frame, since it is only 1/1440 = ~0.07% of the total data set)?