search

marineusde / larapex-charts

A Laravel wrapper for apex charts
https://github.com/marineusde/larapex-charts
MIT License
6 stars 2 forks source link

Updated y-axis label display #20

Closed lukejames1111 closed 3 months ago

lukejames1111 commented 5 months ago

Changed code to directly use the value of $this->show instead of using a ternary operator.

marineusde commented 4 months ago

Oh sorry, GitHub didn't send me a mail for your request. I will test it next week.

marineusde commented 4 months ago

Good work, thank you! :+1:

Can you update the "YAxisOptionTest" in your branch please:

$this->assertSame('true', $yAxis['show']);

must be now:

$this->assertSame(true, $yAxis['show']);

Its my first open project in github and I didnt know how to configure the pipelines to run phpstan and the unit tests in merge requests :/