search

marinmitev / smarthome

Eclipse SmartHome project
Eclipse Public License 1.0
2 stars 1 forks source link

Rule failure event? #210

Open smhgit opened 8 years ago

smhgit commented 8 years ago

Currently there are two events which are posted: RUNNING & IDLE. I thought of using them to give some notification to the user. The issue is that if there is a failure in the action execution it is not exposed.

Is there currently a way to know if the execution has failed?

(I thought of adding RuleStatusDetail to the IDLE event when it is posted or adding FAILURE event).

dnobel commented 8 years ago

I think what we first need here is the notification concept for ESH. This is discussed here https://www.eclipse.org/forums/index.php/t/1070058/ and there also is an initial PR https://github.com/eclipse/smarthome/pull/459

So I think we should skip the discussion for later. But in general it makes sense to have notifications for failures in rule execution.

dnobel commented 8 years ago

I will mark this stuff with the "enhancement" label. Means it will not be part of the initial PR and we have to move this issues later to ESH or start a forum discussion.