search

marinofelipe / swift-package-info

Swift CLI tool that provides information about a Swift Package
MIT License
76 stars 7 forks source link

Add support for custom xcconfig file #49

Closed mackoj closed 7 months ago

mackoj commented 10 months ago

fix #48

This pull request enables users to specify a custom XCConfig file, providing enhanced control over how project configuration influences its size.

For instance, by including --xcconfig test.xcconfig along with the following file, users can gain insights into the impact of specific settings on project size, such as the generation of Assets.car.

ASSETCATALOG_COMPILER_OPTIMIZATION = space

For further information on XCConfig files:

mackoj commented 10 months ago

Hi @marinofelipe,

I just wanted to let you know that I don't plan to pursue this matter further. If you see fit to integrate it into your project, feel free to make any changes necessary.

Best regards,

marinofelipe commented 10 months ago

Hi @marinofelipe,

HI @mackoj, first of all thanks for the contribution. I'll take some time to review it later.

In general, I really like the idea, build/linker settings and build optimisations definitely influence the binary size. The goal so far was for the project to give a close estimation, this could be great for a more precise report👌.

I just wanted to let you know that I don't plan to pursue this matter further. If you see fit to integrate it into your project, feel free to make any changes necessary.

Best regards,

Ok, I'd be happy to have you further contribute to it, but that's up to you 😄

mackoj commented 10 months ago

Ok, I'd be happy to have you further contribute to it, but that's up to you 😄

Thanks, it's just that I know I won't be able to follow through quickly due to time constraints, so I don't want to hinder the evolution of swift-package-info.

marinofelipe commented 9 months ago

Ok, I'd be happy to have you further contribute to it, but that's up to you 😄

Thanks, it's just that I know I won't be able to follow through quickly due to time constraints, so I don't want to hinder the evolution of swift-package-info.

Thank you, but It's all good, I myself also struggle to find time for it 😅

mackoj commented 9 months ago

Gentle ping @marinofelipe this is just in case you forgot about this PR.

marinofelipe commented 9 months ago

Hi @mackoj, I didn't 😊. The says were quite busy, I'll get back to it later this week

marinofelipe commented 8 months ago

Heads up @mackoj , I'm gonna check this PR this weekend.

mackoj commented 8 months ago

Thanks for the review @marinofelipe I'll try to find time to implement your feedback this week.

mackoj commented 8 months ago

Hi @marinofelipe, I did integrate your feedback.

marinofelipe commented 8 months ago

Hi @marinofelipe, I did integrate your feedback.

Nice, thanks again for your contribution @mackoj, this is a great addition 🚀 ! This will go to the next release, alognside #47 🙌