This feature would make more sense if dyndnsd were not typically run as a daemon. In other words, if it were run by a normal user account, then it might make more sense to utilize $SHELL. But, as the primary way to run this will be as a daemon, the daemon likely won't have an exotic $SHELL.
Plus, it simplifies the code and removes a branch.
mario-campos
commented
5 years ago
This feature would make more sense if
dyndnsdwere not typically run as a daemon. In other words, if it were run by a normal user account, then it might make more sense to utilize$SHELL. But, as the primary way to run this will be as a daemon, the daemon likely won't have an exotic$SHELL.Plus, it simplifies the code and removes a branch.