search

mario-eth / soldeer

Solidity Package Manager written in rust
MIT License
188 stars 19 forks source link

Fix download parallelism #121

Closed beeb closed 1 month ago

beeb commented 1 month ago

Currently, downloads should be performed in parallel but they are not when git dependencies are present. Not sure why. When I test this, it first blocks on the first git dependency, then does the second git dependency once the first has finished, and then downloads the zip's in parallel.

Also, the code for awaiting the futures can be made simpler by using try_join_all.

beeb commented 1 month ago

Ok I managed to significantly improve parallelism by manually spawning a tokio task for each download

beeb commented 1 month ago

Another improvement could be to start unzipping files as soon as they finished downloading