search

mario-eth / soldeer

Solidity Package Manager written in rust
MIT License
188 stars 19 forks source link

chore: enable some more lints #160

Closed DaniPopes closed 2 weeks ago

DaniPopes commented 2 weeks ago

These are copied from Foundry. I've not enabled them all, even if mostly auto-fixable, to not be too invasive because as I understand you're working on a big refactor for 0.4.0.

beeb commented 2 weeks ago

I understand you're working on a big refactor for 0.4.0.

Yes! Happy to see some more lints, I activated them on my refactor branch too. I'm rewriting all the tests at the moment because they are way too slow and mutate some checked files of the repo which is annoying. A lot of tests are run serially too which is not great. Finally, some tests which should not be async are marked async which is also suboptimal.