search

mario-eth / soldeer

Solidity Package Manager written in rust
MIT License
240 stars 26 forks source link

each time random order in remappings.txt #181

Closed macwis closed 1 month ago

macwis commented 2 months ago

Each time run to update, even if the records in remappings.txt do not really change, their order changes. This is causing git diff in my project and unnecessary file changes for the commit.

Actual

Order of records in remappings.txt is random.

Expected

Order of records in remappings.txt is deterministic and if content does not change the lines should not be randomized.

mario-eth commented 2 months ago

I think this is depending on how fast they are downloading. And in which order they finish downloading

maciej-specular commented 2 months ago

ofc I can order the file manually using linux sort command, but imho it's good to produce deterministic results on each run - same intput should give same output, not random

mario-eth commented 2 months ago

Will be marked as bug to solve in 0.4.0

beeb commented 2 months ago

This is already fixed in upcoming 0.4.0, the remappings are sorted