mario-eth / soldeer

Solidity Package Manager written in rust
MIT License
143 stars 13 forks source link

.soldeerignore does not ignore some patterns after exclamation mark #69

Closed ericglau closed 2 weeks ago

ericglau commented 2 weeks ago

My .soldeerignore file is based on my .gitignore file, which has the following from Foundry's default template:

!/broadcast
/broadcast/*/31337/
/broadcast/**/dry-run/

The expectation is that the 31337 and dry-run subdirectories should be ignored, even though /broadcast is not ignored.

However, doing a push still results in those files being included.

For example, this can be seen in the openzeppelin-foundry-upgrades~0.3.1 package after installing it: Screenshot 2024-06-25 at 3 09 10 PM

mario-eth commented 2 weeks ago

this has been solved and merged into main, will enter on the next release.