mario-eth / soldeer

Solidity Package Manager written in rust
MIT License
209 stars 23 forks source link

Skip warning flag on push command #76 #81

Closed Mario-SO closed 3 months ago

Mario-SO commented 3 months ago

Added the flag to the command.rs file

#[arg(long, value_parser = clap::value_parser!(bool))]
pub skip_warnings: Option<bool>,

Plus the logic to skip the warning and tests. The test consists on basically the same as pushing with warning but with the -skip--warnings set to true.

Mario-SO commented 3 months ago

i think I messed up when merging latest changes 😵 I think I should've rebased right?

mario-eth commented 3 months ago

i think I messed up when merging latest changes 😵 I think I should've rebased right?

You mean the commits?

Mario-SO commented 3 months ago

Yes. Just last two commits are for this PR

mario-eth commented 3 months ago

Yes. Just last two commits are for this PR

No worries, i'll squash them