mario-eth / soldeer

Solidity Package Manager written in rust
MIT License
143 stars 13 forks source link

Incorrect dependency format in `foundry.toml` #87

Closed ZeroEkkusu closed 2 days ago

ZeroEkkusu commented 1 week ago

forge soldeer install writes a dependency version string to foundry.toml instead of a SoldeerDependency struct.

Expected:

"@openzeppelin-contracts" = { version = "4.9.2", url = "from.where/retrieved" }

Actual:

"@openzeppelin-contracts" = "4.9.2"

This results in an error when forge build is run.

Error: 
failed to extract foundry config:
foundry config error: invalid type: found string "4.9.2", expected struct SoldeerDependency for setting `dependencies.@openzeppelin-contracts`


Don't forget to check if forge soldeer update still works after changing the format.

Note that installing another version of a dependency overwrites its version string in foundry.toml. Haven't noticed any after effects, though.

mario-eth commented 1 week ago

This will be fixed soon. thanks for reporting