search

mario-eth / soldeer

Solidity Package Manager written in rust
MIT License
185 stars 19 forks source link

Publish 0.8 variant of uniswap-v3 periphery #96

Closed 0xJem closed 4 days ago

0xJem commented 1 month ago

This branch: https://github.com/Uniswap/v3-periphery/tree/0.8

mario-eth commented 1 month ago

Hey the problem with this is that it's not actually a published version which we tend to avoid transforming it into a version if it's not official. It is the project's job to properly manage their versions as Soldeer should not assume versions if they are not explicitly specified.

There is a way to use that by using the git way

soldeer install git@github.com:Uniswap/v3-periphery.git b325bb0905d922ae61fcc7df85ee802e8df5e96c

the b325bb0905d922ae61fcc7df85ee802e8df5e96c commit is the latest one on that branch.

spaceh3ad commented 6 days ago

@mario-eth seems to not work

❯ soldeer install git@github.com:Uniswap/v3-periphery.git b325bb0905d922ae61fcc7df85ee802e8df5e96c

error: invalid value 'git@github.com:Uniswap/v3-periphery.git' for '[DEPENDENCY~VERSION]': The dependency should be in the format <DEPENDENCY>~<VERSION>
mario-eth commented 6 days ago

you have to specify a version even when you install from git

soldeer install uniswap~1.0 git@....