Playlist + toggle fullscreen on and off widens the window

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. Start to play a video with gnome-mplayer
2. go to view -> Playlist to switch it on
3. toggle fullscreen on and off (after a few seconds)

What is the expected output? What do you see instead?
I expect to see the window as it was before I went to fullscreen. Instead
it is wider than before (I guess newWidth = oldWidth + playlistWIdth?)

What version of the product are you using? On what operating system?
mplayer 0.9.8 on Fedora 12 (x86_64)

Please provide any additional information below.
This is nothing critical, just something one might want to fix when there
is nothing else to do ;)
See the screenshots below for visualization of the problem

Original issue reported on code.google.com by klaas.oe...@gmail.com on 2 Jan 2010 at 5:00

Attachments:

GoogleCodeExporter commented 8 years ago

While looking at the screenshots I found out that the height is decreasing 
every time
I switch fullscreen on/off.

Original comment by klaas.oe...@gmail.com on 2 Jan 2010 at 5:03

GoogleCodeExporter commented 8 years ago

I believe this has been fixed in SVN.

Original comment by kdeko...@gmail.com on 3 Jan 2010 at 6:05

GoogleCodeExporter commented 8 years ago

I just tested it, still the same.

Original comment by klaas.oe...@gmail.com on 5 Jan 2010 at 11:04

GoogleCodeExporter commented 8 years ago

Unable to duplicate the screen change you are seeing.

Original comment by kdeko...@gmail.com on 5 Jan 2010 at 1:50

GoogleCodeExporter commented 8 years ago

hmmm...do you have an idea why I am having this problem?

Original comment by klaas.oe...@gmail.com on 5 Jan 2010 at 7:23

GoogleCodeExporter commented 8 years ago

What version does Help -> About say you have? Also might try running from the 
command
line with the -v option and see how that works.

Original comment by kdeko...@gmail.com on 5 Jan 2010 at 10:58

GoogleCodeExporter commented 8 years ago

first of all: this is also happening when showing the media info or details 
(but in
that case the height increases). When showing the playlist AND the details, the
window just gets larger in both dimensions, but stops getting wider once the 
window
width is as wide as my display-width - xfce4-panel-width, but the height keeps
increasing. Maybe this helps.
Help -> About says 0.9.9. output when using the -v option:

$ gnome-mplayer -v /media/sg1500/Video/big_buck_bunny_720p_stereo.ogg 
GNOME MPlayer v0.9.9
vo = vdpau ao = pulse
Running with GIO support
Using volume of 100 from gnome-mplayer preference
opening /media/sg1500/Video/big_buck_bunny_720p_stereo.ogg
is block 0
is character 0
is reg 1
is dir 0
playlist 0
embedded in window id 0x0
opening playlist
playlist detection = 0
adding file:///media/sg1500/Video/big_buck_bunny_720p_stereo.ogg to playlist 
(cancel = 0)
getting file metadata for /media/sg1500/Video/big_buck_bunny_720p_stereo.ogg
Using match: type='signal',interface='com.gnome.mplayer'
Using match: type='signal',interface='org.gnome.SettingsDaemon'
Using match: type='signal',interface='org.gnome.SettingsDaemon.MediaKeys'
Proxy connections and Command connected
playing - file:///media/sg1500/Video/big_buck_bunny_720p_stereo.ogg
is playlist 0
current size = 0 x 0 
Changing window size to 1280 x 720 visible = 1
current size = 1280 x 718 
Changing window size to 1280 x 720 visible = 1
mplayer -profile gnome-mplayer -vo vdpau,xv,x11 -vf-pre yadif,softskip,scale 
-quiet
-slave -identify -volume 100 -framedrop -noconsolecontrols -noidle -osdlevel 0
-nomouseinput -nocache -wid 0x3800052 -ss 0 -ass -noembeddedfonts 
-ass-force-style
FontName=Sans,Italic=0,Bold=0,Outline=0,Shadow=0 -ass-font-scale 1.00 -ass-color
ffffff00 -channels 2 -dvd-device /dev/dvd -af-add
export=/tmp/mplayer-af_exportfiwtoy:512
/media/sg1500/Video/big_buck_bunny_720p_stereo.ogg 
Spawn succeeded for filename /media/sg1500/Video/big_buck_bunny_720p_stereo.ogg
MPlayer SVN-r29800-4.4.2 (C) 2000-2009 MPlayer Team
ERROR: mplayer: could not connect to socket
ERROR: mplayer: No such file or directory
ERROR: Failed to open LIRC support. You will not be able to use your remote 
control.

Playing /media/sg1500/Video/big_buck_bunny_720p_stereo.ogg.
ID_VIDEO_ID=0
[Ogg] stream 0: video (Theora v3.2.1), -vid 0
ID_AUDIO_ID=0
[Ogg] stream 1: audio (Vorbis), -aid 0
Ogg file format detected.
VIDEO:  [theo]  1280x720  24bpp  24.000 fps    0.0 kbps ( 0.0 kbyte/s)
ID_FILENAME=/media/sg1500/Video/big_buck_bunny_720p_stereo.ogg
ID_DEMUXER=ogg
ID_VIDEO_FORMAT=theo
ID_VIDEO_BITRATE=0
ID_VIDEO_WIDTH=1280
ID_VIDEO_HEIGHT=720
ID_VIDEO_FPS=24.000
ID_VIDEO_ASPECT=0.0000
ID_AUDIO_FORMAT=vrbs
ID_AUDIO_BITRATE=0
ID_AUDIO_RATE=48000
ID_AUDIO_NCH=2
ID_LENGTH=595.67
ID_SEEKABLE=1
ID_CHAPTERS=0
ERROR: Couldn't open video filter 'ass'.
ERROR: ASS: cannot add video filter
Opening video filter: [scale]
Opening video filter: [softskip]
Opening video filter: [yadif]
[ass] Init
[ass] Updating font cache.
==========================================================================
Opening video decoder: [ffmpeg] FFmpeg's libavcodec codec family
ERROR: [theora @ 0xad7840]Missing extradata!
ERROR: Could not open codec.
VDecoder init failed :(
Opening video decoder: [theora] Theora/VP3
Movie-Aspect is undefined - no prescaling applied.
[swscaler @ 0xbbbb60]using unscaled yuv420p -> yuv420p special converter
VO: [vdpau] 1280x720 => 1280x720 Planar YV12 
Resizing to 1280 x 720
current size = 1280 x 722 
Changing window size to 1280 x 720 visible = 1
Selected video codec: [theora] vfm: theora (Theora (free, reworked VP3))
==========================================================================
ID_VIDEO_CODEC=theora
==========================================================================
Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
AUDIO: 48000 Hz, 2 ch, s16le, 192.0 kbit/12.50% (ratio: 24000->192000)
ID_AUDIO_BITRATE=192000
ID_AUDIO_RATE=48000
ID_AUDIO_NCH=2
Selected audio codec: [ffvorbis] afm: ffmpeg (FFmpeg Vorbis)
==========================================================================
[export] Exporting to file: /tmp/mplayer-af_exportfiwtoy
[export] Memory mapped to file: /tmp/mplayer-af_exportfiwtoy (0x7f6343f34000)
[export] Exporting to file: /tmp/mplayer-af_exportfiwtoy
[export] Memory mapped to file: /tmp/mplayer-af_exportfiwtoy (0x7f6343f34000)
AO: [pulse] 48000Hz 2ch s16le (2 bytes per sample)
[export] Exporting to file: /tmp/mplayer-af_exportfiwtoy
[export] Memory mapped to file: /tmp/mplayer-af_exportfiwtoy (0x7f6343f34000)
[export] Exporting to file: /tmp/mplayer-af_exportfiwtoy
[export] Memory mapped to file: /tmp/mplayer-af_exportfiwtoy (0x7f6343f34000)
ID_AUDIO_CODEC=ffvorbis
Starting playback...
ERROR: Failed to get value of property 'sub_demux'.
ANS_switch_audio is invalid -1
ID_AUDIO_TRACK=1
ERROR: No bind found for key '0xffe9  '.                         
ERROR: No bind found for key '0xffe9  '.                         
ERROR: No bind found for key '0xffe9  '.                         
ERROR: No bind found for key '0xffe9  '.                         
ERROR: No bind found for key '0xffe9  '.                         
ERROR: No bind found for key '0xffe9  '.                         

Exiting... (Quit)
Thread completing

Original comment by klaas.oe...@gmail.com on 6 Jan 2010 at 9:47

GoogleCodeExporter commented 8 years ago

I made a patch that works better for me and committed it to SVN. I test with the
metacity window manager.

Original comment by kdeko...@gmail.com on 6 Jan 2010 at 6:41

GoogleCodeExporter commented 8 years ago

The width seems to be constant now, but the height is still decreasing (also 
when the
details are visible).
Tested it with xfwm4 and metacity.

Original comment by klaas.oe...@gmail.com on 7 Jan 2010 at 12:09

GoogleCodeExporter commented 8 years ago

Yeah, I am aware of that, but can't seem to fix it, the problem is somewhere in
adjust_layout or allocate_fixed_callback in gui.c. I have literally spent 40-60 
hours
just on this problem on an off, and I just can't seem to figure it out.

Original comment by kdeko...@gmail.com on 7 Jan 2010 at 2:02

GoogleCodeExporter commented 8 years ago

maybe you can find it one day ;)
I am happy with this (because I usually don't press fffffffffff while watching 
a video)

Thanks for the good work so far =)

Original comment by klaas.oe...@gmail.com on 7 Jan 2010 at 2:21

GoogleCodeExporter commented 8 years ago

Original comment by kdeko...@gmail.com on 21 Jan 2010 at 2:17

Changed state: Done

mario0alberto1 / gnome-mplayer

Playlist + toggle fullscreen on and off widens the window #339